removing the notifyAllChildrenRecursivelyThatParentHasReLayouted and …

…the parentHasReLayouted methods as they are no longer needed
davidedc · Aug 7, 2020 · cbbcee5 · cbbcee5
1 parent b4b2647
commit cbbcee5
Show file tree

Hide file tree

Showing 42 changed files with 7 additions and 123 deletions.
diff --git a/src/BasementWdgt.coffee b/src/BasementWdgt.coffee
@@ -163,7 +163,6 @@ class BasementWdgt extends BoxMorph
 
     if @isCollapsed()
       @layoutIsValid = true
-      @notifyAllChildrenRecursivelyThatParentHasReLayouted()
       return
 
     @rawSetBounds newBoundsForThisLayout
@@ -191,4 +190,3 @@ class BasementWdgt extends BoxMorph
 
     super
     @layoutIsValid = true
-    @notifyAllChildrenRecursivelyThatParentHasReLayouted()
diff --git a/src/CodePromptMorph.coffee b/src/CodePromptMorph.coffee
@@ -94,7 +94,6 @@ class CodePromptMorph extends Widget
 
     if @isCollapsed()
       @layoutIsValid = true
-      @notifyAllChildrenRecursivelyThatParentHasReLayouted()
       return
 
     # here we are disabling all the broken
@@ -146,5 +145,4 @@ class CodePromptMorph extends Widget
 
     super
     @layoutIsValid = true
-    @notifyAllChildrenRecursivelyThatParentHasReLayouted()
 
diff --git a/src/ColorPickerMorph.coffee b/src/ColorPickerMorph.coffee
@@ -65,7 +65,6 @@ class ColorPickerMorph extends Widget
 
     if @isCollapsed()
       @layoutIsValid = true
-      @notifyAllChildrenRecursivelyThatParentHasReLayouted()
       return
 
     # here we are disabling all the broken
@@ -96,7 +95,6 @@ class ColorPickerMorph extends Widget
 
     super
     @layoutIsValid = true
-    @notifyAllChildrenRecursivelyThatParentHasReLayouted()
 
     if Automator? and Automator.state != Automator.IDLE and Automator.alignmentOfMorphIDsMechanism
       world.alignIDsOfNextMorphsInSystemTests()
diff --git a/src/EmptyButtonMorph.coffee b/src/EmptyButtonMorph.coffee
@@ -86,7 +86,6 @@ class EmptyButtonMorph extends Widget
 
     if @isCollapsed()
       @layoutIsValid = true
-      @notifyAllChildrenRecursivelyThatParentHasReLayouted()
       return
 
     @rawSetBounds newBoundsForThisLayout
@@ -96,7 +95,6 @@ class EmptyButtonMorph extends Widget
 
     super
     @layoutIsValid = true
-    @notifyAllChildrenRecursivelyThatParentHasReLayouted()
 
   # TODO
   getTextDescription: ->

diff --git a/src/ErrorsLogViewerMorph.coffee b/src/ErrorsLogViewerMorph.coffee
@@ -124,7 +124,6 @@ class ErrorsLogViewerMorph extends Widget
 
     if @isCollapsed()
       @layoutIsValid = true
-      @notifyAllChildrenRecursivelyThatParentHasReLayouted()
       return
 
     @rawSetBounds newBoundsForThisLayout
@@ -181,6 +180,4 @@ class ErrorsLogViewerMorph extends Widget
 
     super
     @layoutIsValid = true
-    @notifyAllChildrenRecursivelyThatParentHasReLayouted()
-
 
diff --git a/src/HandleMorph.coffee b/src/HandleMorph.coffee
@@ -214,7 +214,7 @@ class HandleMorph extends Widget
     switch @type
       # 1. all these changes applied to the target are all deferred
       # 2. the position of this handle will be changed when the
-      # parentHasReLayouted method of this handle will be called
+      # doLayout method of the parent of the handle will be called
       # ...i.e. *after* the parent has re-layouted (in the deferred layout phase).
       when "resizeBothDimensionsHandle"
         newExt = newPos.add(@extent().add(@inset)).subtract @target.position()

diff --git a/src/PromptMorph.coffee b/src/PromptMorph.coffee
@@ -72,7 +72,6 @@ class PromptMorph extends MenuMorph
   reLayout: ->
     super()
     @buildSubmorphs()
-    @notifyAllChildrenRecursivelyThatParentHasReLayouted()
 
   buildSubmorphs: ->
 

diff --git a/src/SaveShortcutPromptWdgt.coffee b/src/SaveShortcutPromptWdgt.coffee
@@ -40,7 +40,6 @@ class SaveShortcutPromptWdgt extends MenuMorph
   reLayout: ->
     super()
     @buildSubmorphs()
-    @notifyAllChildrenRecursivelyThatParentHasReLayouted()
 
   buildSubmorphs: ->
 

diff --git a/src/ScriptWdgt.coffee b/src/ScriptWdgt.coffee
@@ -107,7 +107,6 @@ class ScriptWdgt extends Widget
 
     if @isCollapsed()
       @layoutIsValid = true
-      @notifyAllChildrenRecursivelyThatParentHasReLayouted()
       return
 
     # here we are disabling all the broken
@@ -155,5 +154,4 @@ class ScriptWdgt extends Widget
 
     super
     @layoutIsValid = true
-    @notifyAllChildrenRecursivelyThatParentHasReLayouted()
 
diff --git a/src/SimpleLinkWdgt.coffee b/src/SimpleLinkWdgt.coffee
@@ -62,7 +62,6 @@ class SimpleLinkWdgt extends Widget
 
     if @isCollapsed()
       @layoutIsValid = true
-      @notifyAllChildrenRecursivelyThatParentHasReLayouted()
       return
 
     # here we are disabling all the broken
@@ -102,5 +101,4 @@ class SimpleLinkWdgt extends Widget
 
     super
     @layoutIsValid = true
-    @notifyAllChildrenRecursivelyThatParentHasReLayouted()
 
diff --git a/src/SimplePlainTextWdgt.coffee b/src/SimplePlainTextWdgt.coffee
@@ -199,5 +199,3 @@ class SimplePlainTextWdgt extends TextMorph2
     @silentRawSetExtent new Point width, height
 
     @changed()
-    @notifyAllChildrenRecursivelyThatParentHasReLayouted()
-
diff --git a/src/SpeechBubbleWdgt.coffee b/src/SpeechBubbleWdgt.coffee
@@ -72,7 +72,6 @@ class SpeechBubbleWdgt extends Widget
 
     if @isCollapsed()
       @layoutIsValid = true
-      @notifyAllChildrenRecursivelyThatParentHasReLayouted()
       return
 
     # here we are disabling all the broken
@@ -103,7 +102,6 @@ class SpeechBubbleWdgt extends Widget
 
     super
     @layoutIsValid = true
-    @notifyAllChildrenRecursivelyThatParentHasReLayouted()
 
     if Automator? and Automator.state != Automator.IDLE and Automator.alignmentOfMorphIDsMechanism
       world.alignIDsOfNextMorphsInSystemTests()

diff --git a/src/StretchableCanvasWdgt.coffee b/src/StretchableCanvasWdgt.coffee
@@ -188,7 +188,6 @@ class StretchableCanvasWdgt extends CanvasMorph
 
     if @isCollapsed()
       @layoutIsValid = true
-      @notifyAllChildrenRecursivelyThatParentHasReLayouted()
       return
 
     # here we are disabling all the broken
@@ -215,7 +214,6 @@ class StretchableCanvasWdgt extends CanvasMorph
 
     super
     @layoutIsValid = true
-    @notifyAllChildrenRecursivelyThatParentHasReLayouted()
 
     if Automator? and Automator.state != Automator.IDLE and Automator.alignmentOfMorphIDsMechanism
       world.alignIDsOfNextMorphsInSystemTests()
diff --git a/src/StretchableEditableWdgt.coffee b/src/StretchableEditableWdgt.coffee
@@ -72,7 +72,6 @@ class StretchableEditableWdgt extends Widget
       world.alignIDsOfNextMorphsInSystemTests()
 
     @layoutIsValid = true
-    @notifyAllChildrenRecursivelyThatParentHasReLayouted()
 
   rawSetExtent: (aPoint) ->
     super

diff --git a/src/StretchablePanelWdgt.coffee b/src/StretchablePanelWdgt.coffee
@@ -49,7 +49,6 @@ class StretchablePanelWdgt extends PanelWdgt
 
     if @isCollapsed()
       @layoutIsValid = true
-      @notifyAllChildrenRecursivelyThatParentHasReLayouted()
       return
 
     # here we are disabling all the broken
@@ -79,7 +78,6 @@ class StretchablePanelWdgt extends PanelWdgt
 
     super
     @layoutIsValid = true
-    @notifyAllChildrenRecursivelyThatParentHasReLayouted()
 
     if Automator? and Automator.state != Automator.IDLE and Automator.alignmentOfMorphIDsMechanism
       world.alignIDsOfNextMorphsInSystemTests()

diff --git a/src/StretchableWidgetContainerWdgt.coffee b/src/StretchableWidgetContainerWdgt.coffee
@@ -123,7 +123,6 @@ class StretchableWidgetContainerWdgt extends Widget
 
     if @isCollapsed()
       @layoutIsValid = true
-      @notifyAllChildrenRecursivelyThatParentHasReLayouted()
       return
 
     #console.log "spanel @contents: " + @contents + " doLayout 2"
@@ -175,7 +174,6 @@ class StretchableWidgetContainerWdgt extends Widget
 
     super
     @layoutIsValid = true
-    @notifyAllChildrenRecursivelyThatParentHasReLayouted()
 
     if Automator? and Automator.state != Automator.IDLE and Automator.alignmentOfMorphIDsMechanism
       world.alignIDsOfNextMorphsInSystemTests()

diff --git a/src/WidgetHolderWithCaptionWdgt.coffee b/src/WidgetHolderWithCaptionWdgt.coffee
@@ -65,7 +65,6 @@ class WidgetHolderWithCaptionWdgt extends Widget
 
     if @isCollapsed()
       @layoutIsValid = true
-      @notifyAllChildrenRecursivelyThatParentHasReLayouted()
       return
 
     @rawSetBounds newBoundsForThisLayout
@@ -107,7 +106,6 @@ class WidgetHolderWithCaptionWdgt extends Widget
 
     super
     @layoutIsValid = true
-    @notifyAllChildrenRecursivelyThatParentHasReLayouted()
 
     if Automator? and Automator.state != Automator.IDLE and Automator.alignmentOfMorphIDsMechanism
       world.alignIDsOfNextMorphsInSystemTests()
diff --git a/src/apps/DashboardsWdgt.coffee b/src/apps/DashboardsWdgt.coffee
@@ -98,6 +98,4 @@ class DashboardsWdgt extends StretchableEditableWdgt
       world.alignIDsOfNextMorphsInSystemTests()
 
     @layoutIsValid = true
-    @notifyAllChildrenRecursivelyThatParentHasReLayouted()
-
 
diff --git a/src/apps/PatchProgrammingWdgt.coffee b/src/apps/PatchProgrammingWdgt.coffee
@@ -82,6 +82,4 @@ class PatchProgrammingWdgt extends StretchableEditableWdgt
       world.alignIDsOfNextMorphsInSystemTests()
 
     @layoutIsValid = true
-    @notifyAllChildrenRecursivelyThatParentHasReLayouted()
-
 
diff --git a/src/apps/ReconfigurablePaintWdgt.coffee b/src/apps/ReconfigurablePaintWdgt.coffee
@@ -508,5 +508,4 @@ class ReconfigurablePaintWdgt extends StretchableEditableWdgt
       world.alignIDsOfNextMorphsInSystemTests()
 
     @layoutIsValid = true
-    @notifyAllChildrenRecursivelyThatParentHasReLayouted()
 
diff --git a/src/apps/SimpleDocumentWdgt.coffee b/src/apps/SimpleDocumentWdgt.coffee
@@ -133,7 +133,6 @@ class SimpleDocumentWdgt extends Widget
 
     if @isCollapsed()
       @layoutIsValid = true
-      @notifyAllChildrenRecursivelyThatParentHasReLayouted()
       return
 
     # here we are disabling all the broken
@@ -175,7 +174,6 @@ class SimpleDocumentWdgt extends Widget
 
     super
     @layoutIsValid = true
-    @notifyAllChildrenRecursivelyThatParentHasReLayouted()
 
   # same as simpledocumentscrollpanel, you can lock the contents.
   # worth factoring it out as a mixin?

diff --git a/src/apps/SimpleSlideWdgt.coffee b/src/apps/SimpleSlideWdgt.coffee
@@ -149,6 +149,4 @@ class SimpleSlideWdgt extends StretchableEditableWdgt
       world.alignIDsOfNextMorphsInSystemTests()
 
     @layoutIsValid = true
-    @notifyAllChildrenRecursivelyThatParentHasReLayouted()
-
 
diff --git a/src/basic-widgets/SliderButtonMorph.coffee b/src/basic-widgets/SliderButtonMorph.coffee
@@ -60,8 +60,6 @@ class SliderButtonMorph extends CircleBoxMorph
 
       @silentFullRawMoveTo new Point(posX, posY).add @parent.position()
 
-      @notifyAllChildrenRecursivelyThatParentHasReLayouted()
-
   grabsToParentWhenDragged: ->
     if @parent instanceof SliderMorph
       return false

diff --git a/src/basic-widgets/StringFieldMorph.coffee b/src/basic-widgets/StringFieldMorph.coffee
@@ -49,8 +49,6 @@ class StringFieldMorph extends PanelWdgt
       @add @text
     @text.fullRawMoveTo @position()
     @silentRawSetExtent new Point Math.max(@width(), @minTextWidth), @text.height()
-    @notifyAllChildrenRecursivelyThatParentHasReLayouted()
-
 
   getValue: ->
     @text.text

diff --git a/src/basic-widgets/StringFieldWdgt2.coffee b/src/basic-widgets/StringFieldWdgt2.coffee
@@ -50,8 +50,6 @@ class StringFieldWdgt2 extends PanelWdgt
     @text.fullRawMoveTo @position().add new Point 5,2
     @text.rawSetExtent new Point 300, 18
     @silentRawSetExtent new Point @width(), 18
-    @notifyAllChildrenRecursivelyThatParentHasReLayouted()
-
 
   getValue: ->
     @text.text

diff --git a/src/basic-widgets/StringMorph.coffee b/src/basic-widgets/StringMorph.coffee
@@ -94,7 +94,6 @@ class StringMorph extends Widget
     super()
     width = @widthOfText @text
     @silentRawSetExtent new Point width, fontHeight @fontSize
-    @notifyAllChildrenRecursivelyThatParentHasReLayouted()
 
   reflowText: ->
     @reLayout()

diff --git a/src/basic-widgets/TextMorph.coffee b/src/basic-widgets/TextMorph.coffee
@@ -124,7 +124,6 @@ class TextMorph extends StringMorph
       @silentRawSetExtent new Point @maxLineWidth + shadowWidth, height
     else
       @silentRawSetExtent new Point @maxTextWidth + shadowWidth, height
-    @notifyAllChildrenRecursivelyThatParentHasReLayouted()
 
   # no changes of position or extent should be
   # performed in here

diff --git a/src/basic-widgets/TriggerMorph.coffee b/src/basic-widgets/TriggerMorph.coffee
@@ -81,10 +81,9 @@ class TriggerMorph extends Widget
 
     @color = WorldMorph.preferencesAndSettings.menuBackgroundColor
     if @labelString?
-      @layoutSubmorphs()
+      @reLayout()
 
-  layoutSubmorphs: (morphStartingTheChange = nil) ->
-    super()
+  reLayout: ->
     if not @label?
       @createLabel()
     if @centered
@@ -105,18 +104,18 @@ class TriggerMorph extends Widget
     # from scratch
     if @label?
       @label = @label.fullDestroy()
-    @layoutSubmorphs()
+    @reLayout()
   # this part is excluded from the fizzygum homepage build <<«
 
   alignCenter: ->
     if !@centered
       @centered = true
-      @layoutSubmorphs()
+      @reLayout()
 
   alignLeft: ->
     if @centered
       @centered = false
-      @layoutSubmorphs()
+      @reLayout()
 
 
   # This method only paints this very morph's "image",
Original file line number	Diff line number	Diff line change
Expand Up		@@ -199,5 +199,3 @@ class SimplePlainTextWdgt extends TextMorph2
		@silentRawSetExtent new Point width, height

		@changed()
		@notifyAllChildrenRecursivelyThatParentHasReLayouted()
Original file line number	Diff line number	Diff line change
Expand Up		@@ -98,6 +98,4 @@ class DashboardsWdgt extends StretchableEditableWdgt
		world.alignIDsOfNextMorphsInSystemTests()

		@layoutIsValid = true
		@notifyAllChildrenRecursivelyThatParentHasReLayouted()
Original file line number	Diff line number	Diff line change
Expand Up		@@ -82,6 +82,4 @@ class PatchProgrammingWdgt extends StretchableEditableWdgt
		world.alignIDsOfNextMorphsInSystemTests()

		@layoutIsValid = true
		@notifyAllChildrenRecursivelyThatParentHasReLayouted()
Original file line number	Diff line number	Diff line change
Expand Up		@@ -508,5 +508,4 @@ class ReconfigurablePaintWdgt extends StretchableEditableWdgt
		world.alignIDsOfNextMorphsInSystemTests()

		@layoutIsValid = true
		@notifyAllChildrenRecursivelyThatParentHasReLayouted()
Original file line number	Diff line number	Diff line change
Expand Up		@@ -149,6 +149,4 @@ class SimpleSlideWdgt extends StretchableEditableWdgt
		world.alignIDsOfNextMorphsInSystemTests()

		@layoutIsValid = true
		@notifyAllChildrenRecursivelyThatParentHasReLayouted()