limit exported symbol visibility to avoid conflicts with cmfrec

david-cortes · Aug 24, 2021 · 03a73b6 · 03a73b6
1 parent faf99d1
commit 03a73b6
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 2 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: poismf
 Type: Package
 Title: Factorization of Sparse Counts Matrices Through Poisson Likelihood
-Version: 0.3.1-1
+Version: 0.3.1-2
 Authors@R: c(
   person(given="David", family="Cortes", role=c("aut", "cre", "cph"),
          email="david.cortes.rivera@gmail.com"),

diff --git a/MANIFEST.in b/MANIFEST.in
@@ -18,6 +18,7 @@ exclude poismf/*.cpp
 exclude poismf/*.h
 exclude poismf/*.hpp
 exclude src/Makevars
+exclude src/poismf-win.def
 exclude src/rwrapper.c
 exclude DESCRIPTION
 exclude NAMESPACE

diff --git a/src/poismf-win.def b/src/poismf-win.def
@@ -0,0 +1,3 @@
+LIBRARY poismf.dll
+EXPORTS
+ R_init_poismf
diff --git a/src/poismf.h b/src/poismf.h
@@ -78,6 +78,7 @@ extern "C" {
     #include <R.h>
     #include <R_ext/Rdynload.h>
     #include <R_ext/Print.h>
+    #include <R_ext/Visibility.h>
     #define fprintf(f, ...) REprintf(__VA_ARGS__)
     #define sparse_ix int
     #undef USE_FLOAT

diff --git a/src/rwrapper.c b/src/rwrapper.c
@@ -316,7 +316,7 @@ static const R_CallMethodDef callMethods [] = {
     {NULL, NULL, 0}
 }; 
 
-void R_init_poismf(DllInfo *info)
+void attribute_visible R_init_poismf(DllInfo *info)
 {
     R_registerRoutines(info, NULL, callMethods, NULL, NULL);
     R_useDynamicSymbols(info, TRUE);