Enable generation of Reports from a List of Features #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Embeddings are not written to volume when while deserialization
Codecov Report
@@ Coverage Diff @@
## master #959 +/- ##
============================================
- Coverage 97.91% 97.77% -0.15%
- Complexity 555 565 +10
============================================
Files 54 54
Lines 1153 1168 +15
Branches 99 102 +3
============================================
+ Hits 1129 1142 +13
- Misses 9 11 +2
Partials 15 15
Continue to review full report at Codecov.
|
damianszczepanik
requested changes
Sep 4, 2020
| * | ||
| * @return stats for the generated report | ||
| */ | ||
| public Reportable generateReportsFromFiles(List<String> pathsTojsonFiles) { |
There was a problem hiding this comment.
this changes the API - will you update also maven and jenkins plugin which use this library as dependency?
|
|
||
| private void generateEmbeddings() { | ||
| // create directory for embeddings before files are generated | ||
| createEmbeddingsDirectory(); |
There was a problem hiding this comment.
I think you have already removed this method by second PR?
|
|
||
| reportResult.getAllFeatures().forEach(feature -> { | ||
| for (Element element : feature.getElements()) { | ||
| for (Hook hook : element.getAfter()) { |
| for (Hook hook : element.getAfter()) { | ||
| storeEmbedding(hook.getEmbeddings(), configuration.getEmbeddingDirectory()); | ||
| } | ||
| for (Hook hook : element.getBefore()) { |
There was a problem hiding this comment.
... should be after before :)
| File file = new File(configuration.getEmbeddingDirectory(), embedding.getFileName()); | ||
| assertThat(file).exists(); | ||
| } | ||
| // private void assertEmbeddingFileExist(Embedding embedding) { |
There was a problem hiding this comment.
unused method should be removed, not commented out
git keeps history of changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is just a rough idea how you got enable generation of the Reports from a List of Features