remove logger from default build

cs126334 · Mar 4, 2016 · 7a1eb52 · 7a1eb52
1 parent b981e2d
commit 7a1eb52
Showing 6 changed files with 23 additions and 20 deletions.
diff --git a/.gitignore b/.gitignore
@@ -3,3 +3,4 @@ node_modules
 TODO.md
 lib
 docs/_book
+logger.js
diff --git a/build/build.js b/build/build.js
@@ -19,24 +19,16 @@ rollup.rollup({
   plugins: [babel()]
 })
 .then(function (bundle) {
-  return write('dist/vuex.js', bundle.generate({
+  var code = bundle.generate({
     format: 'umd',
     banner: banner,
     moduleName: 'Vuex'
-  }).code)
-})
-.then(function () {
-  // Standalone Production Build
-  return rollup.rollup({
-    entry: 'src/index.js',
-    plugins: [babel()]
+  }).code
+  return write('dist/vuex.js', code).then(function () {
+    return code
   })
 })
-.then(function (bundle) {
-  var code = bundle.generate({
-    format: 'umd',
-    moduleName: 'Vuex'
-  }).code
+.then(function (code) {
   var minified = banner + '\n' + uglify.minify(code, {
     fromString: true,
     output: {
@@ -45,6 +37,16 @@ rollup.rollup({
   }).code
   return write('dist/vuex.min.js', minified)
 })
+.then(function () {
+  return rollup.rollup({
+    entry: 'src/middlewares/logger.js',
+    plugins: [babel()]
+  }).then(function (bundle) {
+    return write('logger.js', bundle.generate({
+      format: 'cjs'
+    }).code)
+  })
+})
 .catch(logError)
 
 function write (dest, code) {

diff --git a/examples/chat/vuex/store.js b/examples/chat/vuex/store.js
@@ -1,6 +1,7 @@
 import Vue from 'vue'
 import Vuex from '../../../src'
 import mutations from './mutations'
+import createLogger from '../../../src/middlewares/logger'
 
 Vue.use(Vuex)
 
@@ -33,6 +34,6 @@ export default new Vuex.Store({
   },
   mutations,
   middlewares: process.env.NODE_ENV !== 'production'
-    ? [Vuex.createLogger()]
+    ? [createLogger()]
     : []
 })
diff --git a/examples/todomvc/vuex/middlewares.js b/examples/todomvc/vuex/middlewares.js
@@ -1,5 +1,5 @@
 import { STORAGE_KEY } from './store'
-import Vuex from '../../../src'
+import createLogger from '../../../src/middlewares/logger'
 
 const localStorageMiddleware = {
   onMutation (mutation, { todos }) {
@@ -8,5 +8,5 @@ const localStorageMiddleware = {
 }
 
 export default process.env.NODE_ENV !== 'production'
-  ? [Vuex.createLogger(), localStorageMiddleware]
+  ? [createLogger(), localStorageMiddleware]
   : [localStorageMiddleware]
diff --git a/package.json b/package.json
@@ -5,7 +5,8 @@
   "main": "dist/vuex.js",
   "files": [
     "dist",
-    "src"
+    "src",
+    "logger.js"
   ],
   "scripts": {
     "counter": "cd examples/counter && webpack-dev-server --inline --hot --config ../webpack.shared.config.js",

diff --git a/src/index.js b/src/index.js
@@ -1,6 +1,5 @@
 import { mergeObjects, deepClone } from './util'
 import devtoolMiddleware from './middlewares/devtool'
-import createLogger from './middlewares/logger'
 import override from './override'
 
 let Vue
@@ -241,6 +240,5 @@ function install (_Vue) {
 
 export default {
   Store,
-  install,
-  createLogger
+  install
 }
-Original file line number
+Diff line change
@@ @@ -3,3 +3,4 @@ node_modules @@
     TODO.md
     lib
     docs/_book
+    logger.js