removed method TCPConnection.on_passive_close()

Even though this method is conceptually correct, it is useless because neither WISP nor fetch() support closing only our half of the TCP connection.
copy · Nov 26, 2024 · 5a3b77d · 5a3b77d
1 parent 0e98beb
commit 5a3b77d
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 12 deletions.
diff --git a/src/browser/fake_network.js b/src/browser/fake_network.js
@@ -1131,7 +1131,7 @@ TCPConnection.prototype.process = function(packet) {
             // dbg_log(`TCP[${this.tuple}]: received FIN in state "${this.state}, next "${TCP_STATE_CLOSE_WAIT}""`, LOG_FETCH);
             reply.tcp.ack = true;
             this.state = TCP_STATE_CLOSE_WAIT;
-            this.on_passive_close();
+            // NOTE that we should forward the CLOSE event from the guest here, but neither WISP nor fetch() support that
         }
         else if(this.state === TCP_STATE_FIN_WAIT_1) {
             if(packet.tcp.ack) {
@@ -1237,9 +1237,6 @@ TCPConnection.prototype.close = function() {
     this.pump();
 };
 
-TCPConnection.prototype.on_passive_close = function() {
-};
-
 TCPConnection.prototype.release = function() {
     if(this.net.tcp_conn[this.tuple]) {
         // dbg_log(`TCP[${this.tuple}]: connection closed in state "${this.state}"`, LOG_FETCH);

diff --git a/src/browser/wisp_network.js b/src/browser/wisp_network.js
@@ -219,14 +219,6 @@ WispNetworkAdapter.prototype.send = function(data)
                 }
             };
 
-            tcp_conn.on_passive_close = () => {
-                this.send_wisp_frame({
-                    type: "CLOSE",
-                    stream_id: tcp_conn.stream_id,
-                    reason: 0x02    // 0x02: Voluntary stream closure
-                });
-            };
-
             this.send_wisp_frame({
                 type: "CONNECT",
                 stream_id: tcp_conn.stream_id,