Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the order-pipelines command to allow for selecting teams #8724

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixing the order-pipelines command to allow for selecting teams #8724

wants to merge 3 commits into from
+13 −10

Conversation

jdziat
Copy link

@jdziat jdziat commented Apr 9, 2023 •
edited
Loading

Changes proposed by this PR

Allows users to specify the team that they are ordering pipelines for. Currently it errors out since it uses the default team no matter what when listing pipelines.

  • fixing fly ordering pipeline logic to correctly default or used passed in team param.

Notes to reviewer

Should be relatively straightforward to test this out. Verified working against a version 7.9.0 concourse instance.

Release Note

  • fix order-pipelines command

@jdziat jdziat requested a review from a team as a code owner April 9, 2023 14:38
jdziat added 2 commits April 9, 2023 10:41
@jdziat
Fixing the order-pipelines command to allow for selecting teams
8970f00 
Signed-off-by: Jordan Dziat <jdziat@ltvco.com>
@jdziat
Signing
f6c3bea 
Signed-off-by: Jordan Dziat <jdziat@ltvco.com>
@jdziat jdziat force-pushed the ordering-pipelines-fix branch from 340d3aa to f6c3bea Compare April 9, 2023 14:41
@xtremerui xtremerui added the bug label Apr 10, 2023
@xtremerui
Copy link
Contributor

There is test failure here

Fly CLI ordering-pipeline when pipeline names are specified when the alphabetical option is passed [It] orders all the pipelines in alphabetical order

github.com/concourse/concourse/fly/integration/ordering_pipelines_test.go:106


  Timeline >>

  logging in to team 'main'



target saved

  error: Unexpected Response

  Status: 500 Internal Server Error

@jdziat
Adding team selection to ordering-pipelines command
437148c 
Signed-off-by: Jordan Dziat <jdziat@ltvco.com>
@jdziat
Copy link
Author

jdziat commented Apr 10, 2023

There is test failure here

Fly CLI ordering-pipeline when pipeline names are specified when the alphabetical option is passed [It] orders all the pipelines in alphabetical order

github.com/concourse/concourse/fly/integration/ordering_pipelines_test.go:106


  Timeline >>

  logging in to team 'main'



target saved

  error: Unexpected Response

  Status: 500 Internal Server Error

Not sure I have access to that build. I was able to successfully run this against a concourse instance.

@xtremerui
Copy link
Contributor

There are still test failures

Fly CLI ordering-pipeline when pipeline names are specified when the pipeline exists [It] orders the pipelines

github.com/concourse/concourse/fly/integration/ordering_pipelines_test.go:49


  Timeline >>

  logging in to team 'main'



target saved

  error: Unexpected Response

  Status: 500 Internal Server Error

  Body: 

  [FAILED] in [It] - github.com/onsi/gomega@v1.27.1/ghttp/handlers.go:76 @ 04/10/23 18:12:43.055


  Attempt #1 Failed.  Retrying ↺ @ 04/10/23 18:12:43.056


  logging in to team 'main'

I would suggest to run the full test in https://github.com/concourse/concourse/tree/master/fly/integration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdziat @xtremerui