Discard unsupported FUNDING.yml URL values #12247
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewnicols
force-pushed
the
skipInvalidFormatFundingOnImport
branch
from
69e27fd to
5c07d1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is intended as an interim solution for #12245 but some form of this should probably be present anyway even after that issue is sorted.
At the moment if a GitHub repo uses a FUNDING.yml in the format documented by GitHub then that entire branch will be skipped from import into Packagist beacuse some of the documented formats are not supported by Packagist/Composer.
As a worst case I would expect the unsupported data to be removed. This isn't critical data - it's optional metadata which is not even present in the composer.json file and which is correct per the GitHub documentation.
On our side I'm trying to get the GitHub FUNDING.yml updated but many of the branches this issue exists on are archived branches which we do not normally modify.
At the moment the Packagist management view shows the following warning:
This suggests that if any of our branches contain 'invalid' data that the entire package will be rejected.