fix(xt): websocket token recreated on each watch_ call, causing 429 error #24809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The token retrieved from the API was stored as a string in client.subscriptions['token']. However, when attempting to access it, the method self.safe_dict(client.subscriptions, 'token') was used, which expects a dictionary. As a result, it returned None due to the type mismatch, causing issues when calling private API endpoints.
danilbogdan
requested review from
kroitor,
frosty00 and
carlosmiei
as code owners
danilbogdan
changed the title
danilbogdan
changed the title
danilbogdan
changed the title
|
Hello @danilbogdan, thanks for fixing it, we will review and merge it shortly |
kroitor
pushed a commit
that referenced
this pull request
Jan 9, 2025
…rror (#24809) * Update xt.py The token retrieved from the API was stored as a string in client.subscriptions['token']. However, when attempting to access it, the method self.safe_dict(client.subscriptions, 'token') was used, which expects a dictionary. As a result, it returned None due to the type mismatch, causing issues when calling private API endpoints. * fix(xt): token reading * revert --------- Co-authored-by: carlosmiei <43336371+carlosmiei@users.noreply.github.com> [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During calls of private watch_ methods, The token retrieved from the API was stored as a string in
client.subscriptions['token']. However, when attempting to access it, the methodself.safe_dict(client.subscriptions, 'token')was used, which expects a dictionary. As a result, it returned None due to the type mismatch, causing another call to ws-token API, which than reachesRateLimitExceeded: 429 Too Many Requests.