Codecov Report

Merging #886 into master will decrease coverage by 0.39%.
The diff coverage is 28.4%.

@@            Coverage Diff            @@
##           master     #886     +/-   ##
=========================================
- Coverage   60.42%   60.02%   -0.4%     
=========================================
  Files         153      153             
  Lines       10774    10833     +59     
=========================================
- Hits         6510     6503      -7     
- Misses       3521     3585     +64     
- Partials      743      745      +2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1ae687...cbe6eba. Read the comment docs.

I thought you wanted to use logrorate directly ? At least that's what we discussed in the issue

@Geod24 Hmm, logrotate utility is one of our options. It can be a simple solution to support a rotating log, but under docker, environment to make logrotate to be working needs some additional efforts. I think the rotating log should be the native feature for considering the various deploying environments.

@spikeekips : What kind of additional effort ? It should be a few (<10) LoC in sebak and a configuration file.

@Geod24 :) For instance, like these
https://www.google.co.kr/search?q=do+ker+logrotate&ie=UTF-8&oe=UTF-8&hl=en-kr&client=safar . Basicslly docker runs one entrypoint, so the daemon like logrotate should be deployed by task manager in docker.