Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Distributions: Add option to hide bars #4301

Merged
merged 1 commit into from
Dec 30, 2019
Merged

[ENH] Distributions: Add option to hide bars #4301

merged 1 commit into from
Dec 30, 2019

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Dec 27, 2019

Issue

Resolves #4119.

Description of changes
  • Add a checkbox for hiding bars; add an attribute 'hidden' to bars and don't paint when it's True
  • Move the check box for cummulative distributions to the box below; for aesthetics and because it belongs there more than above (though both would be OK)
  • Fill curves when bars are hidden
  • Move legend to the plot above, so that it appears above curves
Includes
  • Code changes
  • Tests
  • Documentation

@janezd janezd mentioned this pull request Dec 27, 2019
Closed
@codecov
Copy link

codecov bot commented Dec 27, 2019

Codecov Report

Merging #4301 into master will increase coverage by <.01%.
The diff coverage is 98.36%.

@@            Coverage Diff            @@
##           master   #4301      +/-   ##
=========================================
+ Coverage   86.69%   86.7%   +<.01%     
=========================================
  Files         396     396              
  Lines       71561   71618      +57     
=========================================
+ Hits        62039   62095      +56     
- Misses       9522    9523       +1

@janezd janezd changed the title OWDistributions: Add option to hide bars [ENH] Distributions: Add option to hide bars Dec 27, 2019
@ajdapretnar
Copy link
Contributor

Really nice.

@ajdapretnar ajdapretnar merged commit 3b2abb0 into biolab:master Dec 30, 2019
@prdubois
Copy link

prdubois commented Feb 7, 2020

Thanks so much for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Distributions: impossible to hide bars and get just smooth kernel density lines
3 participants
@janezd @ajdapretnar @prdubois