[FIX] Color widget failed after removing Variable.make #4041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezd
force-pushed
the
owcolor-fix-after-unmake
branch
from
0052234 to
8405d7f
Compare
Codecov Report
@@ Coverage Diff @@
## master #4041 +/- ##
==========================================
+ Coverage 85.47% 85.55% +0.07%
==========================================
Files 385 385
Lines 69107 69059 -48
==========================================
+ Hits 59068 59080 +12
+ Misses 10039 9979 -60 |
janezd
force-pushed
the
owcolor-fix-after-unmake
branch
2 times, most recently
from
d006834 to
e9d639b
Compare
|
@janezd: you intentionally deleted ordered_values, right? |
Yes. We haven't use them, as far as I know and check. |
markotoplak
force-pushed
the
owcolor-fix-after-unmake
branch
from
e9d639b to
a98b2d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
After removing
Variable.make,OWColorfails when loading settings because it tries to setVariable.namewhen loading settings.The widget was misbehaving badly.
set_dataconstructed the output table(!) and modified its attributes (not only colors but also names!). This most probably also brokeDomain's dictionary_indices.Description of changes
Fixing this required reimplementing the way in which the widget stores the data. Instead of storing variables, it stores the data (names, colors) and constructs variables before sending output.
#3822 could have also been the result of the questionable behaviour of the widget and may be fixed with this PR.
Includes