Add web-components #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-wing
requested changes
Nov 2, 2023
There was a problem hiding this comment.
CLA (Contributor License Agreement). Please
https://github.com/binbat/joyrtc/blob/main/.github/CLA.md#L46-L47
On the other hand, I don't build :-p
% npm run build
> webrtc-debuger@0.0.0 build
> tsc && vite build
../webcomponents/index.ts:2:31 - error TS2307: Cannot find module 'react' or its corresponding type declarations.
2 import { DOMAttributes } from "react"
~~~~~~~
../webcomponents/model/joy-rtc.ts:1:22 - error TS2307: Cannot find module 'nipplejs' or its corresponding type declarations.
1 import nipplejs from "nipplejs";
~~~~~~~~~~
../webcomponents/model/joy-rtc.ts:84:25 - error TS7006: Parameter '_' implicitly has an 'any' type.
84 instance1.on("move", (_, data) => {
~
../webcomponents/model/joy-rtc.ts:84:28 - error TS7006: Parameter 'data' implicitly has an 'any' type.
84 instance1.on("move", (_, data) => {
~~~~
../webcomponents/model/joy-rtc.ts:101:25 - error TS7006: Parameter '_' implicitly has an 'any' type.
101 instance2.on("move", (_, data) => {
~
../webcomponents/model/joy-rtc.ts:101:28 - error TS7006: Parameter 'data' implicitly has an 'any' type.
101 instance2.on("move", (_, data) => {
~~~~
Found 6 errors in 2 files.
Errors Files
1 ../webcomponents/index.ts:2
5 ../webcomponents/model/joy-rtc.ts:1
rocka
requested changes
Nov 18, 2023
Co-authored-by: rocka <i@rocka.me>
rocka
approved these changes
Dec 4, 2023
a-wing
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to #20 add web-components package in npm, first split the directory and place webcomponent separately in the webcomponents directory to publish to npm. More components ( For example, shortcut panel, level management ... ) will be added in the future.