Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable replication factor for cadence cassandra keyspaces #1202

Open
rglyons opened this issue Dec 15, 2020 · 0 comments
Open

Configurable replication factor for cadence cassandra keyspaces #1202

rglyons opened this issue Dec 15, 2020 · 0 comments

Comments

@rglyons
Copy link

rglyons commented Dec 15, 2020

Is your feature request related to a problem? Please describe.
I recently realized that my Cadence/Cassandra deployment was not truly HA, since the keyspaces cadence and cadence_visibility within Cassandra only had replication factors of 1. This meant that any time on of my three cassandra nodes went down, any reads would fail.

Describe the solution you'd like to see
A replication factor argument can be passed to cadence-cassandra-tool at the time of bootstrapping cadence. This is currently being done on this line.

The simplest solution, probably, would be to add the -rf flag to the call of cadence-cassandra-tool, and include the parameter's value in the helm values of the cadence chart. E.g.

# server-job.yaml
# line 76
args: ['sh', '-c', 'cadence-cassandra-tool create -k {{ $storeConfig.cassandra.keyspace }} -rf {{ $storeConfig.cassandra.replicationFactor }}']


# values.yaml
server:
  config:
    persistence:
      default:
        driver: "" # cassandra or sql

        cassandra:
          hosts: []
          # port: 9042
          keyspace: cadence
          user: ""
          password: ""
          existingSecret: ""
          consistency: One
          # datacenter: "us-east-1a"
          # maxQPS: 1000
          # maxConns: 2
          replicationFactor: 1    # <-- add this (with default)

      visibility:
        driver: "" # cassandra or sql

        cassandra:
          hosts: []
          # port: 9042
          keyspace: cadence_visibility
          user: ""
          password: ""
          existingSecret: ""
          consistency: One
          # datacenter: "us-east-1a"
          # maxQPS: 1000
          # maxConns: 2
          replicationFactor: 1    # <-- add this (with default)

Describe alternatives you've considered
There don't seem to be any alternatives to bootstrapping Cadence's keyspaces in Cassandra, save pre-deploying Cassandra and running the cadence-cassandra-tool create command manually.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rglyons