Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

telemetry(amazonq): add metric for transformation type #6284

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

telemetry(amazonq): add metric for transformation type #6284

wants to merge 4 commits into from

Conversation

dhasani23
Copy link
Contributor

@dhasani23 dhasani23 commented Dec 21, 2024 •
edited
Loading

Problem

Be able to tell when a language upgrade vs sql conversion happens.

Solution

Add metric.

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dhasani23 dhasani23 requested review from a team as code owners December 21, 2024 07:46
@github-actions GitHub Actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@dhasani23 dhasani23 changed the title fix(amazonq): don't emit entire spawnResult in telemetry telemetry(amazonq): add metric for transformation type Dec 21, 2024
justinmk3
justinmk3 reviewed Dec 23, 2024
View reviewed changes
packages/core/src/amazonqGumby/chat/controller/controller.ts
await this.messenger.sendSelectSQLMetadataFileMessage(message.tabID)
}
} catch (err: any) {
getLogger().error(`Error handling SQL conversion: ${err}`)
Copy link
Contributor

@justinmk3 justinmk3 Dec 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: if the exception is caught then run() won't reflect a result=Failed.

If handleSQLConversion is called from a command or webview, the extension global handler will log the error and show a useful message to the user. If not, then the next best approach is to let the exception through, but add .catch(...) to the run() call.

Same for the other case in this PR.

@dhasani23 dhasani23 requested a review from justinmk3 December 25, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntarakad-aws ntarakad-aws ntarakad-aws approved these changes

@justinmk3 justinmk3 Awaiting requested review from justinmk3

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhasani23 @justinmk3 @ntarakad-aws