MBS-12101 Rework ownership plugin (#1249)

avito-tech · Oct 12, 2021 · 5576e5f · 5576e5f
1 parent b4d1b4b
commit 5576e5f
Show file tree

Hide file tree

Showing 14 changed files with 339 additions and 403 deletions.
diff --git a/...dle/code-ownership/src/gradleTest/kotlin/com/avito/android/CodeOwnershipValidationTest.kt b/...dle/code-ownership/src/gradleTest/kotlin/com/avito/android/CodeOwnershipValidationTest.kt
diff --git a/...-ownership/src/gradleTest/kotlin/com/avito/android/ConfigurationCacheCompatibilityTest.kt b/...-ownership/src/gradleTest/kotlin/com/avito/android/ConfigurationCacheCompatibilityTest.kt
@@ -19,7 +19,20 @@ internal class ConfigurationCacheCompatibilityTest {
                 id("com.avito.android.code-ownership")
             },
             modules = listOf(
-                AndroidLibModule(name = "lib")
+                AndroidLibModule(
+                    name = "lib",
+                    imports = listOf("import com.avito.android.model.Owner"),
+                    buildGradleExtra = """
+                        |class Speed implements Owner { 
+                        |   String toString() { return "Speed" }
+                        |}
+                        |def speed = new Speed() { }
+                        |
+                        |ownership {
+                        |    owners = [speed]
+                        |}
+                    """.trimMargin()
+                )
             )
         ).generateIn(projectDir)
 
@@ -31,8 +44,8 @@ internal class ConfigurationCacheCompatibilityTest {
     private fun runTask(tempDir: File): TestResult {
         return gradlew(
             tempDir,
-            "checkProjectDependenciesOwnership",
-            "-Pavito.moduleOwnershipValidationEnabled",
+            "exportCodeOwnershipInfo",
+            "-Pavito.ownership.strictOwnership=true",
             dryRun = true,
             configurationCache = true
         )

diff --git a/.../gradle/code-ownership/src/gradleTest/kotlin/com/avito/android/ExportOwnershipInfoTest.kt b/.../gradle/code-ownership/src/gradleTest/kotlin/com/avito/android/ExportOwnershipInfoTest.kt
@@ -0,0 +1,94 @@
+package com.avito.android
+
+import com.avito.test.gradle.TestProjectGenerator
+import com.avito.test.gradle.dependencies.GradleDependency.Safe.CONFIGURATION.IMPLEMENTATION
+import com.avito.test.gradle.dependencies.GradleDependency.Safe.Companion.project
+import com.avito.test.gradle.gradlew
+import com.avito.test.gradle.module.AndroidAppModule
+import com.avito.test.gradle.module.AndroidLibModule
+import com.avito.test.gradle.module.KotlinModule
+import com.avito.test.gradle.plugin.plugins
+import org.junit.Assert.assertEquals
+import org.junit.Assert.assertTrue
+import org.junit.jupiter.api.Test
+import org.junit.jupiter.api.io.TempDir
+import java.io.File
+
+internal class ExportOwnershipInfoTest {
+
+    @Test
+    internal fun `ownership exporting to csv file - works correctly`(@TempDir projectDir: File) {
+        TestProjectGenerator(
+            name = "rootapp",
+            plugins = plugins {
+                id("com.avito.android.code-ownership")
+            },
+            modules = listOf(
+                AndroidAppModule(
+                    "app",
+                    imports = listOf("import com.avito.android.model.Owner"),
+                    plugins = plugins {
+                        id("com.avito.android.module-types")
+                    },
+                    dependencies = setOf(
+                        project(
+                            path = ":feature",
+                            configuration = IMPLEMENTATION
+                        ),
+                        project(
+                            path = ":common",
+                            configuration = IMPLEMENTATION
+                        )
+                    ),
+                    buildGradleExtra = """
+                        |class Speed implements Owner { 
+                        |   String toString() { return "Speed" }
+                        |}
+                        |def speed = new Speed() { }
+                        |
+                        |ownership {
+                        |    owners = [speed]
+                        |}
+                    """.trimMargin()
+                ),
+                AndroidLibModule(
+                    name = "feature",
+                    imports = listOf("import com.avito.android.model.Owner"),
+                    plugins = plugins {
+                        id("com.avito.android.module-types")
+                    },
+                    buildGradleExtra = """
+                        |class Speed implements Owner {
+                        |   String toString() { return "Speed" }
+                        |}
+                        |class Performance implements Owner { 
+                        |   String toString() { return "Performance" }
+                        |}
+                        |def speed = new Speed() { }
+                        |def performance = new Performance() { }
+                        |
+                        |ownership {
+                        |    owners = [speed, performance]
+                        |}
+                    """.trimMargin()
+                ),
+                KotlinModule(name = "common")
+            )
+        ).generateIn(projectDir)
+
+        gradlew(
+            projectDir,
+            "exportCodeOwnershipInfo",
+        ).assertThat().buildSuccessful()
+
+        val file = File(projectDir, "ownership.csv")
+        assertTrue(file.exists())
+
+        assertEquals("""
+            |:app,"Speed"
+            |:common,""
+            |:feature,"Speed,Performance"
+            |
+        """.trimMargin(), file.readText())
+    }
+}