Add filterNodeArgumentsForWorkerThreads option
#3336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
July 22, 2024 13:58
Conforms to eslint rule for safe Array#filter usage.
Necessary due to default being removed, in favor of explicit filtered execArgv constructed at higher level.
|
This check is failing: Install and test AVA / Install dependencies without using a lockfile (pull_request) I'm not clear why, and the new tests passed in the log. Is it possible this failure is unrelated? |
Co-authored-by: Tommy <tmitchell7@uh.edu>
novemberborn
previously requested changes
Aug 2, 2024
Co-authored-by: Mark Wubben <mark@novemberborn.net>
|
The Linux tests compare reporter output against a known-good version. That specific suite only runs on Linux because it's finicky enough as it is, without adding other environments into the mix. However, it's failing through what looks like a change in this PR: |
|
Not really sure what to change here but I'm moving toward an internal test runner anyway so I'm just dropping it. |
ghost
closed this
|
That's fine, I can take over. |
lib/fork.js
Outdated
| @@ -60,7 +60,7 @@ const createWorker = (options, execArgv) => { | |||
| }; | |||
| }; | |||
|
|
|||
| export default function loadFork(file, options, execArgv = process.execArgv) { | |||
| export default function loadFork(file, options, execArgv) { | |||
There was a problem hiding this comment.
This default assignment is still required.
novemberborn
changed the title
threadArgumentsFilter optionfilterNodeArgumentsForWorkerThreads option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a configuration option
threadArgumentsFilterfor filteringnodeArgumentssent to worker threads. The option is supported only in config files due to accepting a function. When threads are disabled, the filter is ignored and the full unfiltered list of arguments is sent to worker processes.mainis currently failing tests. This patch adds no new failures. All new tests pass. The new feature is documented in06-configuration.md.This enabled me to use natives syntax in threads.
Closes #3207.