Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for atlas cached images #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Jan 4, 2024

I'm just looking at cleaning up and upstreaming the Floem fork of vger-rs.

This change adds support for colored fonts and SVG. This could probably be simplified as rendering atlased colored and non-colored images. I'm looking for feedback as to what approach is desired.

@wtholliday
Copy link
Contributor

Seems like what is being called svg is an image?

@Zoxc
Copy link
Contributor Author

Zoxc commented Jan 5, 2024

Yeah, glyphs and SVGs (for icons) are basically just (small) images here.

@wtholliday
Copy link
Contributor

Could we call them icons instead of svgs?

@Zoxc Zoxc changed the title Add support for colored fonts and SVGs Add support for atlas cached images Jan 7, 2024
@Zoxc
Copy link
Contributor Author

Zoxc commented Jan 7, 2024

I've changed this to just deal with images for now.

toLinear is no longer used for glyphs / masks as that isn't quite correct.

@Zoxc Zoxc marked this pull request as ready for review January 7, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants