Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dummy test PR for ci cov #4

Open
wants to merge 9 commits into
base: cicoveragetesting
Choose a base branch
from
Open

dummy test PR for ci cov #4

wants to merge 9 commits into from

Conversation

asumagic
Copy link
Owner

@asumagic asumagic commented Dec 1, 2023

Contribution in a nutshell

Hey, this could help our community 🌱

Scope

  • I want to get done ...
  • ... and hope to also achieve ...

Notes for reviewing (optional)

This change has these implication which might need attention over here; —how should we tackle this?

Pre-review

  • (if applicable) add an extra_requirements.txt file
  • (if applicable) add database preparation scripts & use symlinks for nested folders (to the level of task READMEs)
  • (if applicable) add a recipe test entry in the depending CSV file under: tests/recipes
  • create a fresh testing environment (install SpeechBrain from cloned repo branch of this PR)
  • (if applicable) run a recipe test for each yaml/your recipe dataset
  • check function comments: are there docstrings w/ arguments & returns? If you're not the verbose type, put a comment every three lines of code (better: every line)
  • use CI locally: pre-commit run -a to check linters; run pytest tests/consistency
  • (optional) run tests/.run-doctests.sh & tests/.run-unittests.sh
  • exhausted patience before clicking « Ready for review » in the merge box 🍄

Note: when merged, we desire to include your PR title in our contributions list, check out one of our past version releases
https://github.com/speechbrain/speechbrain/releases/tag/v0.5.14

Tip: below, on the « Create Pull Request » use the drop-down to select: « Create Draft Pull Request » – your PR will be in draft mode until you declare it « Ready for review »

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant