Simply return an reversed iterator from __reversed__.

Currently you're returning an instance of `FunctionalList` with `self.values` set as a `listreverseiterator` object. The problem with this is that user will think that they got an instance of `FunctionalList` back but when they will try to perform any of the operation like `len()`, `__getitem__`, `__setitem__` etc they will end up in errors. So, IMO it's better to return a simple `listreverseiterator` object.
ambaree · Jul 29, 2014 · d32e707 · d32e707
1 parent a0603f0
commit d32e707
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/magicmethods.markdown b/magicmethods.markdown
@@ -491,7 +491,7 @@ For our example, let's look at a list that implements some functional constructs
             return iter(self.values)
 
         def __reversed__(self):
-            return FunctionalList(reversed(self.values))
+            return reversed(self.values)
 
         def append(self, value):
             self.values.append(value)