-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot pass look_for_keys via FS URL #52
Comments
do you feel like opening a PR for this? I think you could make it work by adding a new keyword argument to the |
Sure! I can see two ways to implement this:
I would naively expect the second option, as it retains the current behavior when On a somewhat independent note: While trying to understand The implementation in the # Either pkey, keyfile, or both are None
# https://github.com/althonos/fs.sshfs/blob/master/fs/sshfs/sshfs.py#L116
pkey, keyfile = (pkey, None) if isinstance(pkey, paramiko.PKey) else (None, pkey)
...
# look_for_keys will always be True, since (None and x) and (x and None) will always None for all x
# https://github.com/althonos/fs.sshfs/blob/master/fs/sshfs/sshfs.py#L134
look_for_keys = True if (pkey and keyfile) is None else False This seems at odds with your statement above.
|
Elaboration on the above: An example implementation (using the second option from above): As part of the tests, I tried to understand the interaction between If that's the desired behavior, I'll make this a PR. |
While it is possible to pass
look_for_keys
to the underlying paramiko Client as followsI am unable to do so when using an FS URL:
Looking at
SSHOpener
, this could be remedied by passinglook_for_keys
in when constructing SSHFS, much like e.g.pkey
is.The text was updated successfully, but these errors were encountered: