-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log warning when Major GC fails to recover significant memory #1235
Open
wweiss-starburst
wants to merge
1
commit into
airlift:master
Choose a base branch
from
wweiss-starburst:wweiss/warn-when-major-gcs-become-problematic
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Log warning when Major GC fails to recover significant memory #1235
wweiss-starburst
wants to merge
1
commit into
airlift:master
from
wweiss-starburst:wweiss/warn-when-major-gcs-become-problematic
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
reviewed
Aug 2, 2024
wendigo
approved these changes
Aug 2, 2024
dain
reviewed
Aug 2, 2024
wweiss-starburst
force-pushed
the
wweiss/warn-when-major-gcs-become-problematic
branch
from
August 2, 2024 18:50
c394d26
to
2852235
Compare
electrum
requested changes
Aug 2, 2024
wweiss-starburst
force-pushed
the
wweiss/warn-when-major-gcs-become-problematic
branch
2 times, most recently
from
August 6, 2024 19:51
06ed441
to
1ccf811
Compare
electrum
reviewed
Aug 8, 2024
wweiss-starburst
force-pushed
the
wweiss/warn-when-major-gcs-become-problematic
branch
3 times, most recently
from
August 9, 2024 01:21
cead9c7
to
846685b
Compare
PR has been updated to support the Z collector. Note that when Generational is not enabled, the logging is noisy because it does not distinguish major and minor collections. |
wweiss-starburst
force-pushed
the
wweiss/warn-when-major-gcs-become-problematic
branch
3 times, most recently
from
August 9, 2024 20:28
7541724
to
a3f079d
Compare
MBean names for reference G1:
ZGC:
ZGC Generational:
|
electrum
reviewed
Aug 13, 2024
wweiss-starburst
force-pushed
the
wweiss/warn-when-major-gcs-become-problematic
branch
from
August 20, 2024 08:33
a3f079d
to
8eec730
Compare
wweiss-starburst
force-pushed
the
wweiss/warn-when-major-gcs-become-problematic
branch
from
August 29, 2024 16:13
8eec730
to
8de9aed
Compare
wweiss-starburst
force-pushed
the
wweiss/warn-when-major-gcs-become-problematic
branch
from
September 26, 2024 14:39
8de9aed
to
88fe52c
Compare
There are instances where processes spin in GC loops when Major GCs fail to recover enough memory. By providing a warning before this condition is reached, it should be possible to act on the warning by taking a JFR before the JVM completely runs out of memory.
wweiss-starburst
force-pushed
the
wweiss/warn-when-major-gcs-become-problematic
branch
from
December 24, 2024 19:37
88fe52c
to
81d0982
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are instances where processes spin in GC loops when Major GCs fail to recover enough memory. By providing a warning before this condition is reached, it should be possible to act on the warning by taking a JFR before the JVM completely runs out of memory.