Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewind() implementation is not consistent #167

Open
mywave82 opened this issue Feb 26, 2023 · 0 comments
Open

rewind() implementation is not consistent #167

mywave82 opened this issue Feb 26, 2023 · 0 comments
Labels

Comments

@mywave82
Copy link
Contributor

Currently rewind() is prototyped with subsong being signed int, and only rix.cpp and d00.cpp actually has special handling for <0 value, while other subsong implementors does range checks and clamps the value to 0 if out of range. I assume the correct would be to fix other implementors to handle <0 as current song reload instead of clamping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants