fix: set correct exit code for the commands

adonisjs · Nov 30, 2020 · 0047d5b · 0047d5b
1 parent 1ff032c
commit 0047d5b
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 0 deletions.
diff --git a/commands/DbSeed.ts b/commands/DbSeed.ts
@@ -15,6 +15,11 @@ export default class DbSeed extends BaseCommand {
 	public static commandName = 'db:seed'
 	public static description = 'Execute database seeder files'
 
+	/**
+	 * Track if one or more seeders have failed
+	 */
+	private hasError: boolean = false
+
 	/**
 	 * Choose a custom pre-defined connection. Otherwise, we use the
 	 * default connection
@@ -149,12 +154,18 @@ export default class DbSeed extends BaseCommand {
 					status: 'failed',
 					error: new Error('Invalid file path. Pass relative path from the application root'),
 				})
+				this.hasError = true
 			} else {
 				const response = await runner.run(sourceFile)
+				if (response.status === 'failed') {
+					this.hasError = true
+				}
+
 				this.printLogMessage(response)
 			}
 		}
 
+		this.exitCode = this.hasError ? 1 : 0
 		await db.manager.closeAll(true)
 	}
 }
diff --git a/commands/Migration/Base.ts b/commands/Migration/Base.ts
@@ -162,6 +162,7 @@ export default abstract class MigrationsBase extends BaseCommand {
 				break
 			case 'error':
 				this.logger.fatal(migrator.error!)
+				this.exitCode = 1
 				break
 		}
 	}

diff --git a/commands/Migration/Rollback.ts b/commands/Migration/Rollback.ts
@@ -78,6 +78,7 @@ export default class Migrate extends MigrationsBase {
 		 */
 		if (!connection) {
 			this.printNotAValidConnection(this.connection)
+			this.exitCode = 1
 			return
 		}
 

diff --git a/commands/Migration/Run.ts b/commands/Migration/Run.ts
@@ -69,6 +69,7 @@ export default class Migrate extends MigrationsBase {
 		 */
 		if (!connection) {
 			this.printNotAValidConnection(this.connection)
+			this.exitCode = 1
 			return
 		}
 

diff --git a/commands/Migration/Status.ts b/commands/Migration/Status.ts
@@ -62,6 +62,7 @@ export default class Status extends MigrationsBase {
 		 */
 		if (!connection) {
 			this.printNotAValidConnection(this.connection)
+			this.exitCode = 1
 			return
 		}
-Original file line number
+Diff line change
@@ Expand Up @@
     				break
     			case 'error':
     				this.logger.fatal(migrator.error!)
+    				this.exitCode = 1
     				break
     		}
     	}
@@ Expand Down @@