Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add support for commit input (fixes #1634) #1858

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feature: add support for commit input (fixes #1634) #1858

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
650ceb0
added commit input in action.yaml
testersen Aug 20, 2024
67b5caa
in input-helper, set commit = core.getInput('commit')
testersen Aug 20, 2024
8a241b5
in input-helper, make ref fallback to commit if the commit was provid…
testersen Aug 20, 2024
267ca9c
in input-helper, add validation to commit input
testersen Aug 20, 2024
3a6c8fb
added tests
testersen Aug 20, 2024
491fae0
format input-helper
testersen Aug 20, 2024
a52fa92
build updates docs
testersen Aug 20, 2024
1be0f94
builds updates dist
testersen Aug 20, 2024
0865c4b
must use `||` and not `??` when falling back to commit when ref is no…
testersen Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
format input-helper 
Signed-off-by: James Bradlee <james.bradlee@telenor.no>
  • Loading branch information
@testersen
testersen committed Aug 20, 2024
commit 491fae084d7f74ef16e3a7a58a0cdd16edbeb5bf
12 changes: 9 additions & 3 deletions __test__/input-helper.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,9 @@ describe('input-helper tests', () => {
expect(settings.ref).toBeTruthy()
expect(settings.ref).toStrictEqual('refs/pull/123/merge')
expect(settings.commit).toBeTruthy()
expect(settings.commit).toStrictEqual('0123456789012345678901234567890123456789')
expect(settings.commit).toStrictEqual(
'0123456789012345678901234567890123456789'
)
})

it('ref fallbacks to commit if ref is empty but commit is specified', async () => {
Expand All @@ -162,8 +164,12 @@ describe('input-helper tests', () => {
const settings: IGitSourceSettings = await inputHelper.getInputs()
expect(settings).toBeTruthy()
expect(settings.ref).toBeTruthy()
expect(settings.ref).toStrictEqual('0123456789012345678901234567890123456789')
expect(settings.ref).toStrictEqual(
'0123456789012345678901234567890123456789'
)
expect(settings.commit).toBeTruthy()
expect(settings.commit).toStrictEqual('0123456789012345678901234567890123456789')
expect(settings.commit).toStrictEqual(
'0123456789012345678901234567890123456789'
)
})
})