Missing Envoy config dump info (istio#44970)

* add log for envoy config dump * Fix return logic * resolve reviews * Fix test failure
WillardHu · May 19, 2023 · 782c732 · 782c732
1 parent 942a97b
commit 782c732
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/tools/bug-report/pkg/content/content.go b/tools/bug-report/pkg/content/content.go
@@ -19,12 +19,15 @@ import (
 	"strings"
 	"time"
 
+	"github.com/hashicorp/go-multierror"
+
 	"istio.io/istio/istioctl/pkg/util/formatting"
 	"istio.io/istio/pkg/config/analysis/analyzers"
 	"istio.io/istio/pkg/config/analysis/diag"
 	"istio.io/istio/pkg/config/analysis/local"
 	"istio.io/istio/pkg/config/resource"
 	"istio.io/istio/pkg/kube"
+	"istio.io/istio/pkg/util/istiomultierror"
 	"istio.io/istio/tools/bug-report/pkg/common"
 	"istio.io/istio/tools/bug-report/pkg/kubectlcmd"
 	"istio.io/pkg/log"
@@ -183,17 +186,22 @@ func GetIstiodInfo(p *Params) (map[string]string, error) {
 
 // GetProxyInfo returns internal proxy debug info.
 func GetProxyInfo(p *Params) (map[string]string, error) {
+	errs := istiomultierror.New()
 	if p.Namespace == "" || p.Pod == "" {
-		return nil, fmt.Errorf("getIstiodInfo requires namespace and pod")
+		return nil, fmt.Errorf("getProxyInfo requires namespace and pod")
 	}
 	ret := make(map[string]string)
 	for _, url := range common.ProxyDebugURLs(p.ClusterVersion) {
 		out, err := p.Runner.EnvoyGet(p.Namespace, p.Pod, url, p.DryRun)
 		if err != nil {
-			return nil, err
+			errs = multierror.Append(errs, err)
+			continue
 		}
 		ret[url] = out
 	}
+	if errs.ErrorOrNil() != nil {
+		return nil, errs
+	}
 	return ret, nil
 }