Skip to content

Commit

Permalink
all: fix a few function names on comments (istio#41367)
Browse files Browse the repository at this point in the history
Signed-off-by: cui fliter <imcusg@gmail.com>

Signed-off-by: cui fliter <imcusg@gmail.com>
  • Loading branch information
cuishuang authored Oct 12, 2022
1 parent 5c26220 commit 43e3ec8
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions istioctl/cmd/describe.go
Original file line number Diff line number Diff line change
Expand Up @@ -650,7 +650,7 @@ func getInboundHTTPConnectionManager(cd *configdump.Wrapper, port int32) (*http_
return nil, nil
}

// getIstioConfigNameForSvc returns name, namespace
// getIstioVirtualServiceNameForSvc returns name, namespace
func getIstioVirtualServiceNameForSvc(cd *configdump.Wrapper, svc v1.Service, port int32) (string, string, error) {
path, err := getIstioVirtualServicePathForSvcFromRoute(cd, svc, port)
if err != nil {
Expand Down Expand Up @@ -748,7 +748,7 @@ func getIstioConfig(metadata *envoy_api_core.Metadata) (string, error) {
return "", fmt.Errorf("no istio config")
}

// getIstioConfigNameForSvc returns name, namespace
// getIstioDestinationRuleNameForSvc returns name, namespace
func getIstioDestinationRuleNameForSvc(cd *configdump.Wrapper, svc v1.Service, port int32) (string, string, error) {
path, err := getIstioDestinationRulePathForSvc(cd, svc, port)
if err != nil || path == "" {
Expand Down Expand Up @@ -1276,7 +1276,7 @@ func findMatchedConfigs(podsLabels k8s_labels.Set, configs []*config.Config) []*
return cfgs
}

// printConfig prints the applied configs based on the member's type.
// printConfigs prints the applied configs based on the member's type.
// When there is the array is empty, caller should make sure the intended
// log is handled in their methods.
func printConfigs(writer io.Writer, configs []*config.Config) {
Expand Down
2 changes: 1 addition & 1 deletion istioctl/cmd/precheck.go
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ func fromLegacyNetworkingVersion(pod v1.Pod) bool {
return false
}

// CheckListeners checks for workloads that would be broken by https://istio.io/latest/blog/2021/upcoming-networking-changes/
// checkListeners checks for workloads that would be broken by https://istio.io/latest/blog/2021/upcoming-networking-changes/
func checkListeners(cli kube.CLIClient, namespace string) (diag.Messages, error) {
pods, err := cli.Kube().CoreV1().Pods(namespace).List(context.Background(), metav1.ListOptions{
// Find all running pods
Expand Down
2 changes: 1 addition & 1 deletion operator/cmd/mesh/operator-dump.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ func operatorDump(args *RootArgs, odArgs *operatorDumpArgs, l clog.Logger) {
l.Print(output)
}

// validateOutputFormatFlag validates if the output format is valid.
// validateOperatorOutputFormatFlag validates if the output format is valid.
func validateOperatorOutputFormatFlag(outputFormat string) error {
switch outputFormat {
case jsonOutput, yamlOutput:
Expand Down

0 comments on commit 43e3ec8

Please sign in to comment.