Skip to content

Commit

Permalink
Fix istiod and proxy versions are incorrect in bug report (istio#47703)
Browse files Browse the repository at this point in the history
* fix istio version incorrect

* add releasenotes

* remove extra
  • Loading branch information
hanxiaop authored Nov 2, 2023
1 parent 7999247 commit 41bc89a
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 0 deletions.
6 changes: 6 additions & 0 deletions releasenotes/notes/47703.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
apiVersion: release-notes/v2
kind: bug-fix
area: istioctl
releaseNotes:
- |
**Fixed** an issue where sometimes control plane revisions and proxy versions were not obtained in the bug report.
7 changes: 7 additions & 0 deletions tools/bug-report/pkg/bugreport/bugreport.go
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,13 @@ func getIstioRevisions(resources *cluster2.Resources) []string {
}
}
}
for _, podAnnotations := range resources.Annotations {
for annotation, value := range podAnnotations {
if annotation == label2.IoIstioRev.Name {
revMap.Insert(value)
}
}
}
return sets.SortedList(revMap)
}

Expand Down

0 comments on commit 41bc89a

Please sign in to comment.