Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bind kube client configuration flags before instantiating a kube… #1

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

sunilchalla
Copy link

new kubectl-who -care

danielpacak and others added 21 commits August 21, 2019 10:19
this clarifies what `--all-namespaces` does and adds
this to the `README.md`
This introduces a number of changes to enable the `WhoCan` type to be
used in external projects. The `WhoCan` type is exported, and functions
are introduced to allow instances of `WhoCan` and `Action` to be
created. It also modifies the `Check` function to no longer call
`output` to display the results. Instead, `Check` returns the role
bindings that enable an action to be performed. The call to `output` now
takes place in the run function for the command.

Overall, this results in no functional changes to the `kubectl-who-can`
program, but allows it to be imported and used from other projects.

Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
Co-authored-by: Daniel Pacak <pacak.daniel@gmail.com>
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
Co-authored-by: Teppei Fukuda <knqyf263@gmail.com>
This changes all the fields of Action to be exported so that an Action
object can be created from an external package.

Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
Co-authored-by: Daniel Pacak <pacak.daniel@gmail.com>
This updates the `NewWhoCan` method to take a `rest.Config` object
instead of a `ClientConfig` object. This allows the consumer of the API
to use a custom `rest.Config` object rather than relying on the one
created from the `ClientConfig` object.

This also removes the `clientConfig` field from the `WhoCan` object. It
is only used within the `ActionFrom` method, and it is passed in as an
argument. As a result, there is no need to store it on the `WhoCan`
object.

Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
Resolves: #63

Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
Resolves: #57

Co-authored-by: Carol <krol3@users.noreply.github.com>
Co-authored-by: Liz Rice <liz@lizrice.com>
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
@danielpacak danielpacak deleted the branch VineethReddy02:master December 17, 2020 14:24
@danielpacak danielpacak deleted the master branch December 17, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.