forked from aquasecurity/kubectl-who-can
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Bind kube client configuration flags before instantiating a kube… #1
Open
sunilchalla
wants to merge
21
commits into
VineethReddy02:master
Choose a base branch
from
aquasecurity:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this clarifies what `--all-namespaces` does and adds this to the `README.md`
This introduces a number of changes to enable the `WhoCan` type to be used in external projects. The `WhoCan` type is exported, and functions are introduced to allow instances of `WhoCan` and `Action` to be created. It also modifies the `Check` function to no longer call `output` to display the results. Instead, `Check` returns the role bindings that enable an action to be performed. The call to `output` now takes place in the run function for the command. Overall, this results in no functional changes to the `kubectl-who-can` program, but allows it to be imported and used from other projects. Signed-off-by: Bridget McErlean <bmcerlean@vmware.com> Co-authored-by: Daniel Pacak <pacak.daniel@gmail.com>
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com> Co-authored-by: Teppei Fukuda <knqyf263@gmail.com>
This changes all the fields of Action to be exported so that an Action object can be created from an external package. Signed-off-by: Bridget McErlean <bmcerlean@vmware.com> Co-authored-by: Daniel Pacak <pacak.daniel@gmail.com>
This updates the `NewWhoCan` method to take a `rest.Config` object instead of a `ClientConfig` object. This allows the consumer of the API to use a custom `rest.Config` object rather than relying on the one created from the `ClientConfig` object. This also removes the `clientConfig` field from the `WhoCan` object. It is only used within the `ActionFrom` method, and it is passed in as an argument. As a result, there is no need to store it on the `WhoCan` object. Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
Resolves: #63 Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
Resolves: #57 Co-authored-by: Carol <krol3@users.noreply.github.com>
Co-authored-by: Liz Rice <liz@lizrice.com> Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new kubectl-who -care