Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump Maturin to 1.8.1 #959

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Jan 30, 2025

内容

目当てはv1.7.6の PyO3/maturin#2332

あとなんかPython 3.13t(GIL抜きPython)用whlのビルドとかもできるっぽい…
(今後世界的にGIL抜きPythonの需要がどうなるかわかんないので、何とも言えない。もしかすると一年ちょっとくらいで流行る可能性もありうる?)

PyO3が古いままなのが懸念点だったが、なんかまだ普通に動くっぽいので最新版であるMaturin v1.8.1に上げてしまう。

関連 Issue

その他

@qryxip qryxip requested a review from Hiroshiba January 30, 2025 20:23
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@qryxip qryxip merged commit a920e29 into VOICEVOX:main Feb 3, 2025
30 checks passed
@qryxip qryxip deleted the pr/build-bump-maturin-to-1-8-1 branch February 3, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants