Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rust APIとPython APIはリポジトリのLICENSEとREADME.mdを使う #949

Merged

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Jan 26, 2025

内容

Rust APIではシンボリックリンク、Python APIではpyproject.tomlによる指定とする。

Rust APIとしては #913 、Python APIとしては #947 の続きとなる。

関連 Issue

その他

@qryxip qryxip requested a review from Hiroshiba January 26, 2025 15:28
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

シンボリックリンクの表示がこうなるの知らなかった。へ~

@qryxip qryxip merged commit 33578f6 into VOICEVOX:main Jan 26, 2025
30 checks passed
@qryxip qryxip deleted the feat-add-symlinks-to-license-file-and-readme branch January 26, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants