Hide child code entries in main tree #1926
Conversation
which filters child code entries from the code list on top of the normal filtering done by FilteringViewConverter.
The setting has no tooltip as of yet.
also correct accessibility levels in FilteredViewConverter and CodeViewConverter.
|
Download the artifacts for this pull request here: GUI:
CLI: |
🤔 "Hides code entries corresponding to sub-functions of scripts in GMS2.3 games"
Our main focus is UT/DR, and since in DR Ch1&2 scripts containing multiple subfunctions are not common, making the child code entries mostly noise, I feel it would be fair to hide them by default for now |
- Add setting tooltip. - Make the setting on by default.
|
Done and done
It seems neither can I. |
| @@ -60,41 +61,44 @@ | |||
| <CheckBox Grid.Row="5" Grid.Column="2" Margin="3" Content="" IsChecked="{Binding ShowDebuggerOption}"/> | |||
| <TextBlock Grid.Row="5" Grid.Column="2" Margin="25 2 2 2" Text="Show "Run game under GMS debugger" file option" ToolTip="Whether to show the option in the "File" menu. Disabled by default."/> | |||
|
|
|||
| <Separator Grid.Row="6" Grid.ColumnSpan="4" Margin="10"/> | |||
| <CheckBox Grid.Row="6" Grid.Column="0" Margin="3" Content="" IsChecked="{Binding HideChildCodeEntries}"/> | |||
| <TextBlock Grid.Row="6" Grid.Column="0" Margin="25 2 2 2" Text="Hide child code entries" ToolTip="Hides code entries corresponding to sub-functions of scripts in GMS2.3 games."/> | |||
There was a problem hiding this comment.
Can you change it so that the text and/or tooltip mentions that this is for the visible tree-view thingy?
There was a problem hiding this comment.
I wasn't sure how to call it so users would understand so I called it "the asset list". In the tooltip for "Enable asset order swapping" it's called "the asset tabs" but that seems confusing given that there are no tabs in a tree view and now UTMT has tabs for content.
There was a problem hiding this comment.
Has this been resolved?
Changes the code to use SettingsWindow instead of Settings.Instance to better fit with similar code for other settings. Note: this should probably be standardized across all settings.
Description
Implements #1609. Adds a setting to the settings menu to control whether the child code entries (entries which have ParentEntry set) are hidden or shown in the main tree.
Visual Changes
Settings before change:
Settings after change:
Code in main tree before change:
Code in main tree after change (no more gray child entries):
Code in main tree after change with setting off (exact same as before change):
Caveats
The are 2 tiny things that need to be adressed before this can be merged:
Notes
Resolves #1609.