Added way to add creation code in rooms and instances #1901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Based on code from UnderminersTeam#1412)
|
Download the artifacts for this pull request here: GUI:
CLI: |
Miepee
requested changes
Nov 25, 2024
Comment on lines
197
to
204
| if (!IsPreCreate) | ||
| { | ||
| ObjectReference = CreationCode(mainWindow.Data, "gml_RoomCC_" + Room.Name.Content + "_" + RoomGameObject.InstanceID.ToString() + "_Create"); | ||
| } | ||
| else | ||
| { | ||
| ObjectReference = CreationCode(mainWindow.Data, "gml_RoomCC_" + Room.Name.Content + "_" + RoomGameObject.InstanceID.ToString() + "_PreCreate"); | ||
| } |
| @@ -173,6 +215,33 @@ private void Details_Click(object sender, RoutedEventArgs e) | |||
| } | |||
| } | |||
|
|
|||
| // TODO move this to the models | |||
| UndertaleCode CreationCode(UndertaleData data, string name) | |||
There was a problem hiding this comment.
function name feels too generic.
This is adding a code entry, not creation code.
And I'm fairly certain we already have a function in the lib to do exactly that
…rmatted it a little
|
Note that this will need to be changed if #1937 is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made so the little + icon on creation code in rooms and instances can actually create the script instead of giving an error. Fixes #1900. Based on code from #1412.
Caveats
I tried to make it in a way that it could be expanded with other stuff. Maybe you could create derived classes from UndertaleObjectReference instead, so it doesn't clutter it up with a bunch of properties. Also the part that actually creates the code should probably be in the room model, and the part that creates arguments be separated and merged with the one that does that for object events already.
Notes
None