Build create-daml-app with -Werror (digital-asset#12513)

and fix the warning changelog_begin changelog_end
TuranDev · Jan 20, 2022 · 9c03e79 · 9c03e79
1 parent 688f1e1
commit 9c03e79
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/daml-assistant/integration-tests/src/DA/Daml/Assistant/CreateDamlAppTests.hs b/daml-assistant/integration-tests/src/DA/Daml/Assistant/CreateDamlAppTests.hs
@@ -78,7 +78,7 @@ tests =
         -- First test the base application (without the user-added feature).
         withCurrentDirectory cdaDir $ do
           step "Build DAML model for base application"
-          callCommandSilent "daml build"
+          callCommandSilent "daml build --ghc-option=-Werror"
           step "Run JavaScript codegen"
           callCommandSilent $ "daml codegen js -o ui/daml.js .daml/dist/" <> projectName <> "-0.1.0.dar"
           -- We patch all package.json files to point to local files for our TypeScript libraries.
@@ -114,7 +114,7 @@ tests =
           forM_ ["MessageEdit", "MessageList"] $ \messageComponent ->
             assertFileExists ("ui" </> "src" </> "components" </> messageComponent <.> "tsx")
           step "Build the new DAML model"
-          callCommandSilent "daml build"
+          callCommandSilent "daml build --ghc-option=-Werror"
           step "Run JavaScript codegen for new DAML model"
           callCommandSilent $ "daml codegen js -o ui/daml.js .daml/dist/" <> projectName <> "-0.1.0.dar"
           genFiles <- listFilesRecursive "ui/daml.js"

diff --git a/templates/create-daml-app/daml/Setup.daml b/templates/create-daml-app/daml/Setup.daml
@@ -1,6 +1,5 @@
 module Setup where
 
-import DA.Action (unless)
 import DA.Foldable (forA_)
 import qualified DA.Text as T
 import Daml.Script