fix: wrong selection of default audio language #3892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it would always fallback to "en" as the loop was over array keys not values
Bnyro
reviewed
Jan 7, 2025
| @@ -613,7 +613,7 @@ export default { | |||
| // Set the audio language | |||
| const prefLang = this.getPreferenceString("hl", "en").substr(0, 2); | |||
| var lang = "en"; | |||
| for (var l in player.getAudioLanguages()) { | |||
| for (var l of player.getAudioLanguages()) { | |||
There was a problem hiding this comment.
We could actually simplify this more, i.e.
Suggested change
| for (var l of player.getAudioLanguages()) { | |
| const lang = player.getAudioLanguages().includes(prefLang) ? prefLang : "en"; |
but that can be done in a different commit (I'll push that shortly after merging your PR).
Bnyro
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would always fallback to
enas the loop was over array keys, not values.I don't know much about JS but this
for..ofworks in Firefox. Apparently it is ES6 compliant, supported pretty much everywhere except IE11Really needed now that many English tracks of non-English videos are AI translated (because yt enabled it by default) 🤢
Notes:
EDIT: I've added this to a related open feature request #2240 (comment)