Fix infinite loop when emplace() is called with no empty slots #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugoam
force-pushed
the
fix-emplace-no-empty-infinite-loop
branch
from
8e595b5 to
fb159c4
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 1325 1326 +1
=========================================
+ Hits 1325 1326 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
We encountered this, which I believe is a bug, in our usage of ExcaliburHash
Basically, if a HashMap has only Tombstones left, but no Empty slots anymore,
emplace()will loop infinitelyMy attempt to fix, with a very rough understanding of linear probing and tombstones, is that once we've completed a loop over all elements (reached
startItem) we can safely insert in the first encountered tombstone as we are sure there are no duplicate keys