Compound fixe #1154
Open
Compound fixe #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This (and other PRs) need #1153 merged for tests to pass (which need us to figure out what to do about the doc failures). |
|
Maybe just merge that other PR since I think the doc failures are GLMakie related and not relevant for that PR. |
|
(But we need to probably remove GLMakie from the doc dependencies before releasing given how incredibly unstable it is in CI.) |
isaacsas
requested changes
Dec 20, 2024
Comment on lines
+106
to
+107
| ivs_get_expr = :(unique(reduce( vcat, [sorted_arguments(ModelingToolkit.unwrap(comp)) | ||
| for comp in $components]))) |
There was a problem hiding this comment.
Suggested change
| ivs_get_expr = :(unique(reduce( vcat, [sorted_arguments(ModelingToolkit.unwrap(comp)) | |
| for comp in $components]))) | |
| ivs_get_expr = :(unique(reduce( vcat, (sorted_arguments(ModelingToolkit.unwrap(comp)) | |
| for comp in $components)))) |
Does a generator work here instead?
There was a problem hiding this comment.
Probably would, will try and see
|
(Merge once tests pass I mean.) |
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the compound issues in #1151