Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webhook server not streaming command logs #23

Open
singhalkarun opened this issue Jul 4, 2024 · 4 comments
Open

Webhook server not streaming command logs #23

singhalkarun opened this issue Jul 4, 2024 · 4 comments
Assignees
@Srijan-SS02

Comments

@singhalkarun
Copy link
Collaborator

singhalkarun commented Jul 4, 2024 •
edited
Loading

  • Action
  • Webhook Related Files
  • Command to check logs on machine tmux attach-session -t webhook-session (Ctrl + B <-> D), rerun make setup-webhook in case you mistakenly close tmux shell
@singhalkarun singhalkarun changed the title webhook server not streaming command logs Webhook server not streaming command logs Jul 4, 2024
@singhalkarun
Copy link
Collaborator Author

@singhalkarun
Copy link
Collaborator Author

@Srijan-SS02 please spend 2 more hours on this today and if this doesn't work, we will proceed with below options

  1. Look for alternatives that solves for this
  2. Design our own service (fastAPI based) that exposes an API for deployment

@Srijan-SS02
Copy link
Collaborator

Srijan-SS02 commented Aug 5, 2024 •
edited
Loading

  • include-command-output-in-response flag is already used in our hooks.json.template which enables to return data in response but only when the connection is closed. Check here
  • Ability to stream command output as a response, is still not fixed in adnanh webhook
  • Have request for update on the PR from adnanh

@singhalkarun
Copy link
Collaborator Author

  • Current Solution doesn't have an option to stream logs
  • Look for alternatives that solves for this @Srijan-SS02 to spend an hour on this
  • Design our own service (fastAPI based) that exposes an API for deployment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Srijan-SS02 Srijan-SS02

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Srijan-SS02 @singhalkarun