Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create transformer for deprecated composite rules #1520

Merged

Conversation

henriquemoody
Copy link
Member

This transformers will help transition from the current major version to the next. In the current version, it's possible to call allOf, anyOf, noneOf, and oneOf without any arguments or with only one, and that doesn't make much sense.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 94.11765% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.66%. Comparing base (1d6d005) to head (848724e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
library/Transformers/DeprecatedComposite.php 94.11% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1520      +/-   ##
============================================
- Coverage     96.69%   96.66%   -0.04%     
- Complexity     1014     1019       +5     
============================================
  Files           205      206       +1     
  Lines          2511     2545      +34     
============================================
+ Hits           2428     2460      +32     
- Misses           83       85       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This transformers will help transition from the current major version to
the next. In the current version, it's possible to call `allOf`,
`anyOf`, `noneOf`, and `oneOf` without any arguments or with only one,
and that doesn't make much sense.
@henriquemoody henriquemoody force-pushed the core/deprecated-composite branch from b6fdd50 to 848724e Compare January 7, 2025 14:02
@henriquemoody henriquemoody merged commit 848724e into Respect:main Jan 7, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant