Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E-Learning Lab: Unknown shape after undo operation. #1919

Open
yuhongherald opened this issue May 30, 2019 · 4 comments
Open

E-Learning Lab: Unknown shape after undo operation. #1919

yuhongherald opened this issue May 30, 2019 · 4 comments
Labels
f-eLearningLab s.ToInvestigate Requires investigation

Comments

@yuhongherald
Copy link
Contributor

image

PPT 2016, Windows 10

To replicate:

  1. Create a rectangle with appear animation
    1a. Create a rectangle by going Insert > Shape > Rectangle
    1b. While rectangle is still selected, add appear animation by going Animations > Appear.
  2. Open E-Learning Lab PowerPointLabs > E-Learning Lab. There should be an appear animation.
  3. Delete the rectangle while it is selected.
  4. Click Sync on the E-Learning Lab pane.
  5. Repeat steps 1 to 4.
  6. Undo by pressing Ctrl+Z. There will be an unknown shape that appears after the undo operation.
    image

On closer inspection, the name of the Shape is PPTL_Storage.
@damithc
Copy link
Member

damithc commented May 30, 2019

It is the hidden shape eLL uses for storing data?

@LiXiaoooowei
Copy link
Contributor

@damithc That's right. It's the hidden shape.
@yuhongherald Thanks for testing eLL! From the selection pane, you can see that the name of the shape is called PPTL_Storage. This is a hidden shape which stores all information related to eLL explanation items, i.e. the caption text, the callout text, isCallout, isVoice, etc.
Currently when all items are deleted, the in-slide storage shape still exists. Its content is simply an empty root node <SelfExplanationText />.

@yuhongherald yuhongherald added the s.ToInvestigate Requires investigation label Jul 4, 2019
@yuhongherald
Copy link
Contributor Author

yuhongherald commented Jul 4, 2019 •
edited
Loading

The current implementation is fine, but in the event the shape is deleted or the text is edited, the slide data will be lost. Unfortunately, there is no events which we can use to monitor the users actions directly.

@yuhongherald
Copy link
Contributor Author

The required API is related to what #1243 is trying to solve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
f-eLearningLab s.ToInvestigate Requires investigation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@damithc @LiXiaoooowei @yuhongherald @YuPeiHenry