Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot create new shapes category #1898

Open
damithc opened this issue Apr 24, 2019 · 11 comments
Open

Cannot create new shapes category #1898

damithc opened this issue Apr 24, 2019 · 11 comments

Comments

@damithc
Copy link
Member

damithc commented Apr 24, 2019

5.0.0.0 (Dev-release)
Win 10, Office 2016

Steps: open shapes lab, right-click, and choose to create a new category.

Problem: I get this error no matter what name I give

image

@damithc
Copy link
Member Author

damithc commented Apr 24, 2019

I'm also getting this error from time to time. When it happens, I'm left with an extra slide at the end of the slide deck.
image

@YuPeiHenry
Copy link
Contributor

@damithc I can't seem to reproduce the error for being unable to create a new category (dev-release 5.0.0). The condition check for the error message would seem to be if (string.IsNullOrWhiteSpace(name) || invalidChars.IsMatch(name)). It would seem that a possible point of failure is the regex.

@damithc
Copy link
Member Author

damithc commented May 5, 2019

While trying to reproduce, I encountered a different problem in my other computer. There is no place to right-click!
image

@damithc
Copy link
Member Author

damithc commented May 5, 2019

But I couldn't reproduce it in my home computer. Will try again in office computer.

@YuPeiHenry
Copy link
Contributor

While trying to reproduce, I encountered a different problem in my other computer. There is no place to right-click!

Think this is a sizing issue with the panel. Either the user has to increase the width of the panel a little, or the default width should be changed.

@damithc
Copy link
Member Author

damithc commented May 5, 2019

But I couldn't reproduce it in my home computer.

Couldn't reproduce it in the office computer too. 🤔

Think this is a sizing issue with the panel. Either the user has to increase the width of the panel a little, or the default width should be changed.

That may not be apparent to the user. On a related noted, we can add more buttons in this area for

  1. Downloading more shapes
  2. Manage shapes (i.e., same options as those in the the context menu)
  3. Settings

image

@yuhongherald
Copy link
Contributor

yuhongherald commented Jun 7, 2019

Sent by a user. Error details:
PPL version number 5.0.0.0.

The user wants to add a category but giving a name and clicking on the ok button does nothing.
The user only can click cancel.

I am unable to replicate the bug, will be doing a bit more investigation.

@damithc
Copy link
Member Author

damithc commented Jul 4, 2019

On the right-click menu, remove category and rename category don't seem to work either. Nothing happens when I click on them.

@damithc
Copy link
Member Author

damithc commented Jul 4, 2019

@yuhongherald can take a look? While some behaviors mentioned cannot be reproduced, the following can be fixed:

That may not be apparent to the user. On a related noted, we can add more buttons in this area for

  1. Downloading more shapes
  2. Manage shapes (i.e., same options as those in the the context menu)
  3. Settings

image

On the right-click menu, remove category and rename category don't seem to work either. Nothing happens when I click on them.

@yuhongherald
Copy link
Contributor

@damithc I don't seem to be able to replicate the bug. Can you provide more context?

@damithc
Copy link
Member Author

damithc commented Jul 10, 2019

yes, the bug is no longer reproducible. But we can improve the UI as suggested above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants