Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSFilter does not have a destructor #4619

Closed
blenderfan opened this issue Jan 14, 2025 · 1 comment · Fixed by #4620
Closed

CSFilter does not have a destructor #4619

blenderfan opened this issue Jan 14, 2025 · 1 comment · Fixed by #4620
Assignees
@abellgithub

Comments

@blenderfan
Copy link

The class CSFilter, unlike other filters like PMFFilter etc., does not declare or define a destructor. This leads to problems when including the file into other C++ projects, since the unique_ptr holding the CSArgs needs to know how to destruct it.

Expected behavior
Project compiles when including the header "CSFiler.hpp" into another project that uses PDAL as a DLL.
@abellgithub abellgithub self-assigned this Jan 14, 2025
abellgithub added a commit that referenced this issue Jan 14, 2025
@abellgithub
Define destructor in source file for CSFilter.
1b38dc0 
Close #4619
@abellgithub
Copy link
Contributor

To be clear, there's no problem including the file, the problem comes when you need to invoke the destructor of a CSFilter. You can avoid this issue by using StageFactory, but will fix.

@abellgithub abellgithub mentioned this issue Jan 14, 2025
Merged
@hobu hobu closed this as completed in 6ce1de1 Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abellgithub abellgithub

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Define destructor in source file for CSFilter. PDAL/PDAL
2 participants
@abellgithub @blenderfan