Can you clarify? In particular, what is the nature of the retaining the layers and what is odd nature of CATileLayer cleanup? I tried googling around and didn't find any specifics.

I've run profiling for leaks, smashed the simulate memory warnings on a simulator run and it remains clean. Running on hardware (a 3gs) doesn't show any leaks -- but I don't know any tricks to force a memory warning, unless playing InfinityBlade will do it. :)

I've noticed several bits of async invocation in the code, in particular the before/after move and zoom code areas, and also spawning an async tile download in the tile code. Not having large experience with CATileLayer, which seems to be an underdocumented class from Googled comments,I can see it's a bit of a pleasure/pain class in the framework.

On principal I can understand why a rendering class that invokes work in multiple threads could cause some headaches. Still, the point of ARC conversion is to remove hand coded retain/release and have the compiler manage it automagically. If the existing code doesn't have any bugs with regard to handling the references, introducing ARC probably won't add them (crossing fingers).

I
On Oct 5, 2012, at 9:01 PM, Justin R. Miller notifications@github.com wrote:

Have you looked over the subtleties of the map view retaining the tiled layers due to the odd cleanup behavior of CATiledLayer when on a memory-constrained device? It gets tricky.

On Oct 5, 2012, at 8:19 PM, teacup775 notifications@github.com wrote:

I have pulled MapBox's SDK and converted to ARC in 5 minutes. It took only a few lines to comment out for the use of AutoRelease pool in the RMMapTiledLayerView and changes handled in a semi automated way to change retain to "strong" etc.

When you get to it, it won't be all that bad.

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub.

Use Automatic Reference Counting #78

Description

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions