-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
retain cycle #102
Comments
Ok, I see. I added the retain in |
I'd also like to add that RMAnnotation's retain a copy of the map view as well, which causes a similar problem to the RMMapTiledLayerView. |
Any progress on this issue? Can I help? |
I haven't had a chance to check things out in depth yet. @trasch, any luck? |
No, not yet. I'll have a look at it soon, I'll have to do some route-me related stuff anyway. |
I found and fixed another retain cycle. I sent the pull request above, however there seem to be a backlog of pull requests going back five months. Should I be fixing a different branch/fork? |
RMMapView
creates one or moreRMMapTiledLayerView
objects which in turn retain theRMMapView
:https://github.com/Alpstein/route-me/blob/release/MapView/Map/RMMapTiledLayerView.m#L41
When the
RMMapView
is released, this is never explicitly cleaned up. Now that location services are available, removing a map view from the view hierarchy won't necessary turn them off since the map view never goes away from memory.The text was updated successfully, but these errors were encountered: