Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build, CI] - foxx-setup not throwing error when problem #1172

Open
JoshuaSBrown opened this issue Dec 10, 2024 · 0 comments · Fixed by #1176 or #1175
Open

[Build, CI] - foxx-setup not throwing error when problem #1172

JoshuaSBrown opened this issue Dec 10, 2024 · 0 comments · Fixed by #1176 or #1175
Labels
Type: Bug Something isn't working

Comments

@JoshuaSBrown
Copy link
Collaborator

JoshuaSBrown commented Dec 10, 2024 •
edited
Loading

Description

The ci job that is setting up arangodb is not throwing an error if a problem is detected in test_setup.sh script. The -e was apparently removed so that the password file is removed on completion of the setup. Really this should occur in an after_script in the CI job.

Screenshot (222)

Acceptance

Ensure the scripts throws an error if a problem occurs so the job will fail. Add 'set -e' back in and mention as much in the comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@JoshuaSBrown