Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Game hashing #2351

Closed
wants to merge 8 commits into from
Closed

Game hashing #2351

wants to merge 8 commits into from

Conversation

halgari
Copy link
Collaborator

@halgari halgari commented Dec 5, 2024

No description provided.

@erri120
Copy link
Member

erri120 commented Dec 5, 2024

Will take a look when it's ready for review.

@github-actions github-actions bot added the status-needs-rebase Set by CI do not remove label Dec 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

This PR conflicts with main. You need to rebase the PR before it can be merged.

@erri120
Copy link
Member

erri120 commented Dec 9, 2024

You'd probably wanna use JsonAugment on value types instead of making a custom JSON serializer.

@halgari halgari closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status-needs-rebase Set by CI do not remove
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@halgari @erri120