Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
~ Fixed issue where token set for Volare may cause authentication issues by falling back to secrets.GITHUB_TOKEN
~ Update documentation version constraints to accommodate furo bug
  • Loading branch information
donn authored Aug 22, 2023
1 parent b1fb228 commit 17559fa
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 6 deletions.
12 changes: 9 additions & 3 deletions .github/workflows/openlane_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,14 @@ jobs:
# GHR (Pushing)
go install github.com/tcnksm/ghr@latest
- name: Set GITHUB_TOKEN
run: |
if [ "${{ secrets.MY_TOKEN }}" != "" ]; then
echo "GITHUB_TOKEN=${{ secrets.MY_TOKEN }}" >> $GITHUB_ENV
else
echo "GITHUB_TOKEN=${{ secrets.GITHUB_TOKEN }}" >> $GITHUB_ENV
fi
- name: Build (or Get) PDK
run: |
export PATH=$PATH:$(go env GOPATH)/bin
Expand All @@ -41,14 +49,13 @@ jobs:
sudo mkdir -p ${{ env.PDK_ROOT }}
sudo chown -R $USER:$USER ${{ env.PDK_ROOT }}
python3 -m pip install --upgrade --no-cache-dir volare
python3 -m pip install --upgrade --no-cache-dir volare>=0.12.3
export OPDKS_VER="$(python3 ./dependencies/tool.py open_pdks -f commit)"
if [ "${{ vars.VOLARE_REPO }}" != "" ]; then
volare enable_or_build\
--pdk $PDK_FAMILY\
--build-magic\
--also-push\
--token ${{ secrets.MY_TOKEN }}\
--owner ${{ vars.VOLARE_OWNER }}\
--repository ${{ vars.VOLARE_REPO }}\
-j$(nproc)\
Expand All @@ -57,7 +64,6 @@ jobs:
volare enable_or_build\
--pdk $PDK_FAMILY\
--build-magic\
--token ${{ secrets.MY_TOKEN }}\
-j$(nproc)\
$OPDKS_VER
fi
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ mount:

.PHONY: pdk
pdk: venv/created
PYTHONPATH= ./venv/bin/$(PYTHON_BIN) -m pip install --upgrade --no-cache-dir volare
PYTHONPATH= ./venv/bin/$(PYTHON_BIN) -m pip install --upgrade --no-cache-dir volare>=0.12.3
./venv/bin/volare enable --pdk $(PDK_FAMILY)

.PHONY: survey
Expand Down
4 changes: 2 additions & 2 deletions docs/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
furo==2023.5.20
sphinx>=7,<8
furo>=2023.08.19
sphinx>=7.2.2,<8
myst-parser>=2,<3

0 comments on commit 17559fa

Please sign in to comment.