Optimize jQueryInterface in Collapse (twbs#35689)

extracts config initialization from cycle
Mike2l8 · Feb 7, 2022 · a805330 · a805330
1 parent 77e02a0
commit a805330
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/js/src/collapse.js b/js/src/collapse.js
@@ -256,12 +256,12 @@ class Collapse extends BaseComponent {
 
   // Static
   static jQueryInterface(config) {
-    return this.each(function () {
-      const _config = {}
-      if (typeof config === 'string' && /show|hide/.test(config)) {
-        _config.toggle = false
-      }
+    const _config = {}
+    if (typeof config === 'string' && /show|hide/.test(config)) {
+      _config.toggle = false
+    }
 
+    return this.each(function () {
       const data = Collapse.getOrCreateInstance(this, _config)
 
       if (typeof config === 'string') {