Don't install codecov python package.

MichalKuzma21 · Mar 30, 2021 · ccb8803 · ccb8803
1 parent 9568da2
commit ccb8803
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -98,7 +98,7 @@ jobs:
     - uses: twisted/python-info-action@v1
     - name: Install dependencies
       run: |
-        python -m pip install --upgrade pip tox codecov coveralls
+        python -m pip install --upgrade pip tox coveralls
         tox --notest
 
     - name: Test
@@ -110,7 +110,6 @@ jobs:
       # We want to publish coverage even on failure.
       if: always()
       run: |
-        python -m coverage xml -o coverage.xml -i
         # Bash is the recommended uploader.
         # See: https://github.com/codecov/example-python#faq
         bash <(curl -s https://codecov.io/bash) -X search -X gcov -f coverage.xml -n 'lnx-${{ matrix.python-version }}-${{ matrix.tox-env }}${{ matrix.noipv6 }}' -X search -X gcov -f coverage.xml

diff --git a/azure-pipelines/run_test_steps.yml b/azure-pipelines/run_test_steps.yml
@@ -65,7 +65,6 @@ steps:
       TWISTED_REACTOR: ${{ parameters.windowsReactor }}
 
 - bash: |
-    python -m coverage xml -o coverage.xml -i
     bash <(curl -s https://codecov.io/bash) -X search -X gcov -f coverage.xml -n "${{ parameters.platform }}-${{ parameters.pythonVersion }}"
   displayName: 'Generate XML and report to Codecov'
   condition: always()

diff --git a/tox.ini b/tox.ini
@@ -89,7 +89,11 @@ commands =
     withcov: python {toxinidir}/admin/_copy.py {toxinidir}/admin/zz_coverage.pth {envsitepackagesdir}/zz_coverage.pth
     withcov: coverage erase
     withcov: coverage run -p --rcfile={toxinidir}/.coveragerc -m twisted.trial --temp-directory={envtmpdir}/_trial_temp --reactor={env:TWISTED_REACTOR:default} --reporter={env:TRIAL_REPORTER:verbose} {env:TRIAL_ARGS:} {posargs:twisted}
+    ; sub-process coverage are generated in separate files so we combine them
+    ; to get an unified coverage for the local run.
+    ; The XML is generate to be used with 3rd party tools like diff-cover.
     withcov: coverage combine
+    withcov: coverage xml -o coverage.xml -i
 
     lint: pre-commit {posargs:run --all-files --show-diff-on-failure}