Removed multiple arrow heads with DashedVMobject
#4078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
OliverStrait
suggested changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
When a DashedVMobject is made, the arrow is duplicated and overlayed for every segment or 'dash'. This change makes it so that only one arrowhead is seen during it all. Fixes #3220 . Also makes the
TipableVMobject.pop_tips()function more robust if we enter an object that does not have any tips on either side.Motivation and Explanation: Why and how do your changes improve the library?
It fixes an issue I found on the issues tab. I think it makes the usage of dashed arrows and vectors easier and more aesthetically pleasing.
Links to added or changed documentation pages
Further Information and Comments
Fixes the issue given here #3220.
Reviewer Checklist