Now :variables values must be quoted like in setq sexps

Fixes syl20bnr#1596
Kernael · Jun 1, 2015 · 4489de8 · 4489de8
1 parent 4b0c84e
commit 4489de8
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/contrib/auto-completion/README.md b/contrib/auto-completion/README.md
@@ -69,8 +69,8 @@ The default configuration of the layer is:
 ```elisp
 (setq-default dotspacemacs-configuration-layers '(
   (auto-completion :variables
-                   auto-completion-return-key-behavior complete
-                   auto-completion-tab-key-behavior cycle
+                   auto-completion-return-key-behavior 'complete
+                   auto-completion-tab-key-behavior 'cycle
                    auto-completion-complete-with-key-sequence nil)
                    ))
 ```

diff --git a/contrib/ibuffer/README.md b/contrib/ibuffer/README.md
@@ -42,7 +42,7 @@ Example:
 
 ```elisp
 (setq-default dotspacemacs-configuration-layers '(
-  (ibuffer :variables ibuffer-group-buffers-by projects)))
+  (ibuffer :variables ibuffer-group-buffers-by 'projects)))
 ```
 
 ## Key bindings

diff --git a/contrib/shell/README.md b/contrib/shell/README.md
@@ -51,7 +51,7 @@ to the following variables:
 
 ```elisp
 (setq-default dotspacemacs-configuration-layers
-  '(shell :variables shell-default-shell eshell))
+  '(shell :variables shell-default-shell 'eshell))
 ```
 
 The default shell is quickly accessible via a the default shortcut key
@@ -69,7 +69,7 @@ It is also possible to set the default height in percents with the variable
 ```elisp
 (setq-default dotspacemacs-configuration-layers
   '(shell :variables
-          shell-default-position bottom
+          shell-default-position 'bottom
           shell-default-height 30))
 ```
 

diff --git a/core/core-configuration-layer.el b/core/core-configuration-layer.el
@@ -283,7 +283,9 @@ the following keys:
       (while variables
         (let ((var (pop variables)))
           (if (consp variables)
-              (set-default var (pop variables))
+              (progn
+                ;; (message "%s" `(set-default ,var ,(pop variables)))
+                (set-default var (eval (pop variables))))
             (spacemacs-buffer/warning "Missing value for variable %s !"
                                       var)))))))